docs: fix missing links in API_OVERVIEW.md#440
Closed
taiki45 wants to merge 1 commit intoenvoyproxy:masterfrom
Closed
docs: fix missing links in API_OVERVIEW.md#440taiki45 wants to merge 1 commit intoenvoyproxy:masterfrom
taiki45 wants to merge 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Taiki Ono <taiks.4559@gmail.com>
htuch
reviewed
Jan 29, 2018
|
|
||
| * [Cluster Discovery Service (CDS)](api/cds.proto). | ||
| * [Endpoint Discovery Service (EDS)](api/eds.proto). This has the same role as SDS in the [v1 API](https://www.envoyproxy.io/docs/envoy/latest/configuration/cluster_manager/sds_api.html), | ||
| * [Cluster Discovery Service (CDS)](envoy/service/discovery/v2/cds.proto). |
Member
There was a problem hiding this comment.
Unfortunately, this is about to change back in #438, stay tuned. Thanks for jumping in and fixing though.
Member
Author
There was a problem hiding this comment.
Thanks for checking. Got it.
I also found some broken links in sphinx docs, so once the refactoring has been completed, we should run a script to fix all the links.
Closing this temporal fix and wait the on-going refactoring, thanks.
mattklein123
pushed a commit
that referenced
this pull request
May 8, 2018
This PR adds a configuration flag that allows disabling the "eventually consistent" aspect of endpoint updates: instead of waiting for the endpoints to go unhealthy before removing them from the cluster, do so immediately. This gives greater control to the control plane in cases where one might want to divert traffic from an endpoint without having it go unhealthy. The flag goes on the cluster and so applies to all endpoints within that cluster. Risk Level: Low: Small configurable feature which reuses existing behavior (identical to the behavior when no health checker is configured). Defaults to disabled, so should have no impact on existing configurations. Testing: Added unit test for the case when endpoints are healthy then removed from the ClusterLoadAssignment in a subsequent config update. Docs Changes: Docs were added to the proto field. Release Notes: Added cluster: Add :ref:`option <envoy_api_field_Clister.drain_connections_on_eds_removal>` to drain endpoints after they are removed through EDS, despite health status. to the release notes. [Optional Fixes #Issue] #440 and #3276 (note that this last issue also asks for more fine grained control over endpoint removal. The solution this PR provides was brought up as a partial solution to #3276). Signed-off-by: Snow Pettersen <snowp@squareup.com> Mirrored from https://github.com/envoyproxy/envoy @ 08712e93b07695f53d192a2601cfa2ccc7a20f33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To match new subdir layout of #421.
Signed-off-by: Taiki Ono taiks.4559@gmail.com