docs: add new percentage-based response option to health check filter#425
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Jan 22, 2018
brian-pane:health-check-doc/2362
Merged
docs: add new percentage-based response option to health check filter#425mattklein123 merged 2 commits intoenvoyproxy:masterfrom brian-pane:health-check-doc/2362
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
brian-pane:health-check-doc/2362
Conversation
*Description*: Update the documentation to match envoy PR [2387](envoyproxy/envoy#2387) Associated envoyproxy/envoy issue: [2362](envoyproxy/envoy#2362) Signed-off-by: Brian Pane <bpane@pinterest.com>
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM, small comment. Can you also check doc build?
|
|
||
| * **No pass through**: In this mode, the health check request is never passed to the local service. | ||
| Envoy will respond with a 200 or a 503 depending on the current draining state of the server. | ||
| * **No pass through, computed from upstream cluster health**: In this mode, the health checking |
Member
There was a problem hiding this comment.
Might be nice to deep link into v2 doc option that implements this.
… config field Signed-off-by: Brian Pane <bpane@pinterest.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Update the HTTP health check filter documentation to match Envoy PR 2387
Associated envoyproxy/envoy issue: 2362
Signed-off-by: Brian Pane bpane@pinterest.com