-
Notifications
You must be signed in to change notification settings - Fork 273
lds: Add listener_filter_chain. #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mattklein123
merged 16 commits into
envoyproxy:master
from
jrajahalme:listener-filter-chain
Jan 23, 2018
Merged
Changes from 6 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
02b4a5e
lds: Add listener_filter_chain.
jrajahalme 74a163a
lds: Fix spacing.
jrajahalme 113052e
lds: Rename 'listener_filter_chain' to 'listener_filters'
jrajahalme 071ddd9
Merge branch 'master' into listener-filter-chain
jrajahalme 6f24f4d
lds: link to filter_chains in comment.
jrajahalme 0dd802c
lds: Rephrase the comment on 'listener_filters'
jrajahalme 2ce8e72
lds: Define ListenerFilter message type.
jrajahalme 138d110
Merge branch 'master' into listener-filter-chain
jrajahalme 94773bf
Merge branch 'master' into listener-filter-chain
jrajahalme fd02c81
docs: Add basic listener filter documentation.
jrajahalme 5f41ccc
Merge branch 'master' into listener-filter-chain
jrajahalme 11d9ab4
docs: Add listener_filters/listener_filters to toctree.
jrajahalme 362031f
docs: Add arch_overview/listener_filters.rst to the toctree.
jrajahalme a7e6fdf
docs: Remove proxy protocol listener filter from the docs.
jrajahalme d6f8842
docs: Review fixes.
jrajahalme e2a201a
lds: Deprecate 'use_original_dst' flag.
jrajahalme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a completely different type of filter from network filters, should it use a different type to describe it? Right now they have the same set of data, but possibly in the future they could be different. Prior art: HttpFilter is a different type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. I would do a
ListenerFiltertype just in case for future enhancement.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Assuming we don't need the deprecated_v1 stuff, ListenerFilter message now only has the name and config members.