feat: support inferencepool status#979
Merged
mathetake merged 2 commits intoenvoyproxy:mainfrom Aug 5, 2025
Merged
Conversation
Xunzhuo
force-pushed
the
feat-inference-status
branch
9 times, most recently
from
c24990d to
cb0496a
Compare
Xunzhuo
force-pushed
the
feat-inference-status
branch
from
c785de9 to
6dc493f
Compare
mathetake
reviewed
Aug 1, 2025
Member
mathetake
left a comment
mathetake
left a comment
There was a problem hiding this comment.
This is exciting. Thank you for taking a shot
internal/controller/controller.go
Outdated
Comment on lines
+138
to
+148
| inferencePoolC := NewInferencePoolController(c, kubernetes.NewForConfigOrDie(config), logger. | ||
| WithName("inference-pool")) | ||
| if err = TypedControllerBuilderForCRD(mgr, &gwaiev1a2.InferencePool{}). | ||
| Watches(&gwapiv1.Gateway{}, inferencePoolC.gatewayEventHandler()). | ||
| Watches(&aigv1a1.AIGatewayRoute{}, inferencePoolC.routeEventHandler()). | ||
| Watches(&gwapiv1.HTTPRoute{}, inferencePoolC.httpRouteEventHandler()). | ||
| Complete(inferencePoolC); err != nil { | ||
| return fmt.Errorf("failed to create controller for InferencePool: %w", err) | ||
| } |
Member
There was a problem hiding this comment.
does this not fail for the cluster where inferencepool CRD is not installed? If this fails, then shall we make this optional by simply emitting the error log like ("failed to start the inference pool cotroller. This is most likely due to Gateway API Inference Extension CRDs are not installed on the cluster. Please referece to the Envoy AI Gateawy documentation for details."). Alternativel, we can add a flag to the cnotroller like --inferenceExtensionEnabled etc
Signed-off-by: bitliu <bitliu@tencent.com>
Xunzhuo
force-pushed
the
feat-inference-status
branch
5 times, most recently
from
031e779 to
57a046f
Compare
Signed-off-by: bitliu <bitliu@tencent.com>
Xunzhuo
force-pushed
the
feat-inference-status
branch
from
57a046f to
a1fcd08
Compare
mathetake
approved these changes
Aug 5, 2025
missBerg
pushed a commit
to missBerg/ai-gateway
that referenced
this pull request
Dec 20, 2025
**Description** This PR added support for GIE conformance test and inferencepool status computing. Now envoy ai gateway have passed all the GIE upstream conformance tests. And it is running in our CI, make sure future changes wont break the conformance. --------- Signed-off-by: bitliu <bitliu@tencent.com> Signed-off-by: Erica Hughberg <erica.sundberg.90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR added support for GIE conformance test and inferencepool status computing.
Now envoy ai gateway have passed all the GIE upstream conformance tests. And it is running in our CI, make sure future changes wont break the conformance.