examples: use numAttemptsPerPriority in fallback#875
Merged
Conversation
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
commented
Jul 12, 2025
|
|
||
| const ( | ||
| egDefaultVersion = "v1.4.0" | ||
| egDefaultVersion = "v0.0.0-latest" |
Member
Author
|
hoping e2e passes 🤞 |
Xunzhuo
approved these changes
Jul 13, 2025
Member
Xunzhuo
left a comment
Xunzhuo
left a comment
There was a problem hiding this comment.
This is a good improvement, make the retry much clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
numAttemptsPerPriority API was recently introduced in Envoy Gateway which allows users to specify how many times Envoy should send the retry requests to an endpoint in the same priority. For example, let's say when we have a backend p0 and p1 where p0 and p1 has the priority 0 and 1 respectively. Previously, when we want to send a request to p1 on retry, the passive health check must be configured and need to wait for envoy to eject the backend. With this numAttemptsPerPriority API, we no longer need to rely on it and allows us to do the fine-control on the retry backend selection.
Since we dropped v1.4 EG support on the main branch and we are planning to do our next version release based on v1.5 (not released yet), we can showcase this API in our examples now.
Related Issues/PRs (if applicable)
Implemented in EG: envoyproxy/gateway#6204