controller: progpagate obj deletion to Gateways#857
Merged
Conversation
mathetake
commented
Jul 11, 2025
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
force-pushed
the
finalizeraigatewayroute
branch
from
fdc813b to
a770109
Compare
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Xunzhuo
reviewed
Jul 11, 2025
Member
Author
|
That's another topic than finalizer, and planning to work on it in a follow up PR |
Member
|
Yep, that's cool. I am thinking about adding e2e around deletion, make sure the lifecycle of resources is completed |
Member
Author
|
yep, we can do that but i think that controller-only e2e could be done in tests/controller as much as possible for testability/faster iteration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug that the deletion event of AI Gateway resources were not propagated and reflected on the Gateway configuration. This changes the controller code so that it will add a finalizer and handle the deletion even gracefully.
Related Issues/PRs (if applicable)
Closes #728
Necessary for #836