Conversation
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
commented
Jun 9, 2025
| // which should be acceptable for AWS Bedrock or any modern HTTP service. | ||
| // | ||
| // https://github.com/envoyproxy/envoy/blob/60b2b5187cf99db79ecfc54675354997af4765ea/source/extensions/filters/http/ext_proc/processor_state.cc#L180-L183 | ||
| req.ContentLength = -1 |
Member
Author
There was a problem hiding this comment.
still no idea why AWS doesn't complain when the body is small but at least this makes all tests happy
Member
Author
There was a problem hiding this comment.
my best guess is that if there's only one chunk in the request (== small body), then AWS will fill in the content-length with the length of the only chunk and matches the signature. But we'll never know...
Contributor
There was a problem hiding this comment.
ye I think there is some special handling on the AWS side
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
wengyao04
approved these changes
Jun 10, 2025
yuzisun
pushed a commit
to yuzisun/ai-gateway
that referenced
this pull request
Jun 10, 2025
**Commit Message** Previously, AWS signing has included the "content-length" header. However, Envoy's extproc filter strips it from the request as we are using CONTINUE_AND_REPLACE option to reduce the memory overhead. While we have still no clue as to why AWS doesn't complain when the request body is small, excluding content-length from the signing target headers will make the tests with both small and large bodies pass. **Related Issues/PRs (if applicable)** CONTINUE_AND_REPLACE was introduced in envoyproxy#636 to avoid sending a request body twice between Envoy and the ExtProc. --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
yuzisun
added a commit
that referenced
this pull request
Jun 10, 2025
**Commit Message** Previously, AWS signing has included the "content-length" header. However, Envoy's extproc filter strips it from the request as we are using CONTINUE_AND_REPLACE option to reduce the memory overhead. While we have still no clue as to why AWS doesn't complain when the request body is small, excluding content-length from the signing target headers will make the tests with both small and large bodies pass. **Related Issues/PRs (if applicable)** CONTINUE_AND_REPLACE was introduced in #636 to avoid sending a request body twice between Envoy and the ExtProc. Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Co-authored-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
yuzisun
added a commit
to yuzisun/ai-gateway
that referenced
this pull request
Jul 2, 2025
This reverts commit d3c58bb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message
Previously, AWS signing has included the "content-length" header. However, Envoy's extproc filter strips it from the request as we are using CONTINUE_AND_REPLACE option to reduce the memory overhead. While we have still no clue as to why AWS doesn't complain when the request body is small, excluding content-length from the signing target headers will make the tests with both small and large bodies pass.
Related Issues/PRs (if applicable)
CONTINUE_AND_REPLACE was introduced in #636 to avoid sending a request body twice between Envoy and the ExtProc.