fix: prevent panic in extractSubject for malformed bearer Authorization header - #2053
Merged
nacx merged 1 commit intoApr 16, 2026
Merged
Conversation
Add a len(parts) < 2 check before accessing parts[1] in extractSubject to prevent a panic when the Authorization header contains only the bearer scheme with no token. Add a test case covering this path. Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2053 +/- ##
=======================================
Coverage 84.38% 84.38%
=======================================
Files 130 130
Lines 18114 18116 +2
=======================================
+ Hits 15285 15287 +2
Misses 1883 1883
Partials 946 946 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Hello @nacx |
nacx
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
This PR fixes a potential index out of bounds panic in
extractSubjectwhen theAuthorizationheader contains abearerscheme without a token. It adds a defensive length check and a corresponding test case inhandlers_test.go.Fix
Verification
All unit tests pass locally with
go test ./internal/mcpproxy/..., including the newly added case forAuthorization: bearer. The change was also validated by confirming that malformed headers are handled gracefully without causing a panic.