fix: case-sensitive json marshalling and unmarshalling - #1863
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1863 +/- ##
=======================================
Coverage 84.38% 84.38%
=======================================
Files 130 130
Lines 18114 18114
=======================================
Hits 15285 15285
Misses 1883 1883
Partials 946 946 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can we make this configurable? it may break requests that are passing unknown elements or fields not defined on struct |
|
I've updated the change to focus on case-sensitivity, which shouldn't affect unknown fields, etc, that we rely on. |
Signed-off-by: Ignasi Barrera <nacx@apache.org>
Signed-off-by: Ignasi Barrera <nacx@apache.org>
Signed-off-by: Ignasi Barrera <nacx@apache.org>
|
/retest |
Signed-off-by: Ignasi Barrera <nacx@apache.org>
|
@yuzisun can you take a look and approve? This is passing all tests and fixes the security advisory on MCP. |
mathetake
left a comment
There was a problem hiding this comment.
needs benchmark comparison just in case
ai-gateway/tests/data-plane/bench_test.go
Lines 28 to 34 in 45ae2fe
|
|
Nice |
|
@mathetake can you stamp? :) |
|
/retest |
Description
Use strict json marshalling and unmarshalling configuration.
Related Issues/PRs (if applicable)
N/A
Special notes for reviewers (if applicable)
N/A