Skip to content

fix: set the remaining extra fields for inputsShema#1515

Merged
yuzisun merged 5 commits intoenvoyproxy:mainfrom
hustxiayang:fix-anthropic-function-nested-schema
Mar 4, 2026
Merged

fix: set the remaining extra fields for inputsShema#1515
yuzisun merged 5 commits intoenvoyproxy:mainfrom
hustxiayang:fix-anthropic-function-nested-schema

Conversation

@hustxiayang
Copy link
Copy Markdown
Contributor

Description

In the original codes, it drops every thing other than properties. Thus, other data like defs are dropped. it should be stored into extra filelds.

@hustxiayang hustxiayang requested a review from a team as a code owner November 7, 2025 14:21
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 7, 2025
@hustxiayang hustxiayang force-pushed the fix-anthropic-function-nested-schema branch from c8fb831 to 29cb1bb Compare November 7, 2025 18:04
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.29%. Comparing base (04d3f0f) to head (c3475ef).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1515      +/-   ##
==========================================
- Coverage   84.32%   84.29%   -0.03%     
==========================================
  Files         128      128              
  Lines       17545    17546       +1     
==========================================
- Hits        14794    14790       -4     
- Misses       1826     1829       +3     
- Partials      925      927       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mathetake
Copy link
Copy Markdown
Member

looks good to me! deferring to @yuzisun

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 7, 2025
@mathetake mathetake added this to the v0.4.0 milestone Nov 7, 2025
@hustxiayang
Copy link
Copy Markdown
Contributor Author

hustxiayang commented Nov 7, 2025

@mathetake thanks for your free golang tutorial!

@mathetake mathetake removed this from the v0.4.0 milestone Nov 7, 2025
@hustxiayang hustxiayang changed the title fix: set the remaining extra fields. for inputsShema fix: set the remaining extra fields for inputsShema Nov 9, 2025
@hustxiayang hustxiayang force-pushed the fix-anthropic-function-nested-schema branch from 1fc25d1 to 8960a50 Compare November 29, 2025 23:31
@hustxiayang
Copy link
Copy Markdown
Contributor Author

/retest

@nacx
Copy link
Copy Markdown
Member

nacx commented Dec 1, 2025

@yuzisun good to merge?

@mathetake
Copy link
Copy Markdown
Member

ping @yuzisun

Signed-off-by: yxia216 <yxia216@bloomberg.net>
@hustxiayang hustxiayang force-pushed the fix-anthropic-function-nested-schema branch from 3195c45 to b358399 Compare February 9, 2026 15:39
@hustxiayang
Copy link
Copy Markdown
Contributor Author

@yuzisun Please help to review and approve it, thanks!

@yuzisun yuzisun merged commit 77020a7 into envoyproxy:main Mar 4, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants