Skip to content

fix: handle GCP global region#1480

Merged
yuzisun merged 19 commits intoenvoyproxy:mainfrom
xiaolin593:gcp_bugfix
Nov 11, 2025
Merged

fix: handle GCP global region#1480
yuzisun merged 19 commits intoenvoyproxy:mainfrom
xiaolin593:gcp_bugfix

Conversation

@xiaolin593
Copy link
Copy Markdown
Contributor

Description

GCP global region endpoint is different from regional endpoint. Current PR is to handle GCP global region to avoid segfault.

Related PR: #752

Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>
@xiaolin593 xiaolin593 requested a review from a team as a code owner November 4, 2025 05:50
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 4, 2025
@xiaolin593 xiaolin593 changed the title bugfix: handle GCP global region fix: handle GCP global region Nov 4, 2025
Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.93%. Comparing base (4822f8a) to head (ab63360).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1480   +/-   ##
=======================================
  Coverage   83.93%   83.93%           
=======================================
  Files         144      144           
  Lines       12670    12670           
=======================================
+ Hits        10634    10635    +1     
+ Misses       1421     1419    -2     
- Partials      615      616    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>
Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>
Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>
Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>
@xiaolin593
Copy link
Copy Markdown
Contributor Author

@mathetake extproc ubuntu-latest passed but macos-latest failed. Looks like a flaky test? Any suggestion how to fix it?

FAIL
FAIL	github.com/envoyproxy/ai-gateway/tests/extproc/mcp	31.049s

@mathetake
Copy link
Copy Markdown
Member

you can ignore any flaky tests (can re-kick by commenting /retest if you like)

@xiaolin593
Copy link
Copy Markdown
Contributor Author

/retest

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 6, 2025
@xiaolin593
Copy link
Copy Markdown
Contributor Author

/retest

@mathetake mathetake requested a review from yuzisun November 7, 2025 17:21
@mathetake
Copy link
Copy Markdown
Member

@xiaolin593 @yuzisun do we want to get this in v0.4?

yuzisun and others added 5 commits November 10, 2025 08:59
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>
Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>
Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>
Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>
Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>
Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>
Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>
@xiaolin593
Copy link
Copy Markdown
Contributor Author

/retest

@yuzisun yuzisun merged commit 21cc0e4 into envoyproxy:main Nov 11, 2025
49 of 51 checks passed
hustxiayang pushed a commit to hustxiayang/ai-gateway that referenced this pull request Nov 13, 2025
**Description**

GCP global region endpoint is different from regional endpoint. Current
PR is to handle GCP global region to avoid segfault.

Related PR: envoyproxy#752

---------

Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: yxia216 <yxia216@bloomberg.net>
missBerg pushed a commit to missBerg/ai-gateway that referenced this pull request Dec 20, 2025
**Description**

GCP global region endpoint is different from regional endpoint. Current
PR is to handle GCP global region to avoid segfault.

Related PR: envoyproxy#752

---------

Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Erica Hughberg <erica.sundberg.90@gmail.com>
@xiaolin593 xiaolin593 deleted the gcp_bugfix branch January 5, 2026 15:02
mtparet pushed a commit to blackfuel-ai/ai-gateway that referenced this pull request Jan 14, 2026
**Description**

GCP global region endpoint is different from regional endpoint. Current
PR is to handle GCP global region to avoid segfault.

Related PR: envoyproxy#752

---------

Signed-off-by: Xiaolin Lin <xlin158@bloomberg.net>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants