Validate command checks for missing parameter values #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orien
commented
Mar 20, 2020
| failed!(message) | ||
| end | ||
| pv = ParameterValidator.new(stack: @proposed_stack, stack_definition: @stack_definition) | ||
| failed!(pv.error_message) if pv.missing_parameters? |
There was a problem hiding this comment.
Extract this functionality to the new ParameterValidator class.
orien
commented
Mar 20, 2020
|
|
||
| def missing_parameters? | ||
| missing_parameters.any? | ||
| end |
There was a problem hiding this comment.
Extract this functionality to the new ParameterValidator class.
orien
commented
Mar 20, 2020
| StackMaster.stdout.print "#{@stack_definition.stack_name}: " | ||
| template_body = TemplateCompiler.compile(@config, @stack_definition.compiler, @stack_definition.template_dir, @stack_definition.template, compile_time_parameters, @stack_definition.compiler_options) | ||
| cf.validate_template(template_body: TemplateUtils.maybe_compressed_template_body(template_body)) |
There was a problem hiding this comment.
This template compilation logic is duplicated in the Stack class. It all seems to work by just using the Stack class directly via the refactoring in 6af37cb, and it keeps things DRY.
orien
commented
Mar 20, 2020
| if parameter_validator.missing_parameters? | ||
| StackMaster.stdout.puts "invalid\n#{parameter_validator.error_message}" | ||
| return false | ||
| end |
There was a problem hiding this comment.
Validate that all the parameters are provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of the improvement suggested in #189.
There is some custom code in the
applycommand that checks for parameters with no values. If blank parameters are found, it aborts the process and prints a friendly message.In this proposal, the code has been extracted to a separate class,
ParameterValidatorand thevalidatecommand modified to use this check. It prints out the same helpful message if it finds this issue.