Fewer ActiveSupport core extensions #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orien
commented
Mar 16, 2020
| require 'active_support/core_ext/string' | ||
| require 'active_support/core_ext/hash/keys' | ||
| require 'active_support/core_ext/object/blank' | ||
| require 'active_support/core_ext/string/inflections' |
There was a problem hiding this comment.
Previously, when requiring active_support/core_ext/string it'd load all these string extensions:
Which would in turn load a bunch of other core extensions.
Let's be a little more explicit about the extensions StackMaster uses, and only load these.
orien
commented
Mar 16, 2020
| @@ -12,7 +12,7 @@ def resolve(value) | |||
| owners = Array(value.fetch('owners', 'self').to_s) | |||
| ami_finder = AmiFinder.new(@stack_definition.region) | |||
| filters = ami_finder.build_filters_from_hash(value.fetch('filters')) | |||
| ami_finder.find_latest_ami(filters, owners).try(:image_id) | |||
| ami_finder.find_latest_ami(filters, owners)&.image_id | |||
There was a problem hiding this comment.
Now that we require Ruby >= 2.4, we can use the Ruby safe navigation operator, instead of ActiveSupport's try.
orien
commented
Mar 16, 2020
| @@ -71,7 +71,7 @@ def format | |||
| newlines = lines.split("\n").map do |line| | |||
| "#{line}#{newlines.pop}" | |||
| end | |||
| if lines.starts_with?("\n") | |||
| if lines.start_with?("\n") | |||
There was a problem hiding this comment.
Active support aliases Ruby's start_with? to starts_with?.
Let's just use the method that comes with Ruby.
orien
commented
Mar 16, 2020
| @@ -1,6 +1,5 @@ | |||
| #!/usr/bin/env ruby | |||
|
|
|||
| require 'rubygems' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require fewer ActiveSupport core extensions.