Add log of changes #293
Merged
Add log of changes #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orien
commented
Nov 17, 2019
| "bug_tracker_uri" => "https://github.com/envato/stack_master/issues", | ||
| "changelog_uri" => "https://github.com/envato/stack_master/blob/master/CHANGELOG.md", | ||
| "documentation_uri" => "https://www.rubydoc.info/gems/stack_master/#{spec.version}", | ||
| "source_code_uri" => "https://github.com/envato/stack_master/tree/v#{spec.version}", |
There was a problem hiding this comment.
Add some gemspec metadata. This'll become available on the Rubygems project page and via the bundle and gem command line tools after the next release.
orien
commented
Nov 17, 2019
| @@ -20,8 +20,14 @@ Gem::Specification.new do |spec| | |||
| spec.email = ["[email protected]", "[email protected]"] | |||
| spec.summary = %q{StackMaster is a sure-footed way of creating, updating and keeping track of Amazon (AWS) CloudFormation stacks.} | |||
| spec.description = %q{} | |||
| spec.homepage = "https://github.com/envato/stack_master" | |||
| spec.homepage = "https://opensource.envato.com/projects/stack_master.html" | |||
There was a problem hiding this comment.
Given we can specify the source code URI below. Should this be the homepage?
There was a problem hiding this comment.
I believe we're about to deprecate this domain, but it hasn't been migrated yet.
patrobinson
approved these changes
Nov 17, 2019
| @@ -20,8 +20,14 @@ Gem::Specification.new do |spec| | |||
| spec.email = ["[email protected]", "[email protected]"] | |||
| spec.summary = %q{StackMaster is a sure-footed way of creating, updating and keeping track of Amazon (AWS) CloudFormation stacks.} | |||
| spec.description = %q{} | |||
| spec.homepage = "https://github.com/envato/stack_master" | |||
| spec.homepage = "https://opensource.envato.com/projects/stack_master.html" | |||
There was a problem hiding this comment.
I believe we're about to deprecate this domain, but it hasn't been migrated yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This'll help communicate changes to the community. Especially the upcoming v2.0 changes.
Also add project metadata to the gemspec.