Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error when no container #258

Merged
merged 2 commits into from
Nov 5, 2018
Merged

Better error when no container #258

merged 2 commits into from
Nov 5, 2018

Conversation

patrobinson
Copy link
Contributor

@patrobinson patrobinson commented Nov 2, 2018 •
edited
Loading

Context

If you provide a tag and there are some images in ECR, but none that match your tag, then StackMaster supplies an unhelpful error message:

error: undefined method `registry_id' for nil:NilClass. Use --trace to view backtrace

Changes

Ensure it returns a helpful error by returning nil, which will result in the "no value provided for parameter" message.

stevehodgkiss
stevehodgkiss approved these changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@stevehodgkiss stevehodgkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@patrobinson patrobinson merged commit a856409 into master Nov 5, 2018
@patrobinson patrobinson deleted the better-error-when-no-container branch November 5, 2018 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehodgkiss stevehodgkiss stevehodgkiss approved these changes

@mipearson mipearson Awaiting requested review from mipearson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrobinson @stevehodgkiss