Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require console so we can getch in windows #241

Merged
merged 1 commit into from
Jul 5, 2018
Merged

Require console so we can getch in windows #241

merged 1 commit into from
Jul 5, 2018

Conversation

patrobinson
Copy link
Contributor

@patrobinson patrobinson commented Jun 13, 2018 •
edited
Loading

On windows, STDIN.getch returns:

undefined method `getch' for #<IO:<STDIN>> (NoMethodError)
Did you mean?  getc
               gets

Unless we require io/console

simpsora
simpsora approved these changes Jul 5, 2018
View reviewed changes
Copy link
Contributor

@simpsora simpsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

jacobbednarz
jacobbednarz approved these changes Jul 5, 2018
View reviewed changes
Copy link
Contributor

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you want all of io/console here, 👍

@patrobinson patrobinson merged commit 1808f0f into master Jul 5, 2018
@patrobinson patrobinson deleted the fix-windows-getch branch July 5, 2018 21:07
patrobinson pushed a commit that referenced this pull request Jul 5, 2018
Bump version
60eb657 
Fix prompter on Windows #241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viraptor viraptor viraptor approved these changes

@jacobbednarz jacobbednarz jacobbednarz approved these changes

@simpsora simpsora simpsora approved these changes

@petervandoros petervandoros petervandoros approved these changes

@stevehodgkiss stevehodgkiss Awaiting requested review from stevehodgkiss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrobinson @viraptor @jacobbednarz @simpsora @petervandoros