Environment Parameters

[gstib]

This completes GH-170

• Raise an error if the Environment Variable is not set
• Add RSpec's
• Add happy path Cucumber test

[patrobinson]

Looks good, just the edge case I think should be handled differently

[patrobinson]

I think this should be if environment_variable.nil? because an empty parameter might be perfectly legitimate and ENV returns nil if the environment variable is not set

irb(main):007:0> ENV["FOO"]
=> nil
irb(main):008:0> exit
patrickrobinson:$ export FOO=""
patrickrobinson:$ irb
irb(main):001:0> ENV["FOO"]
=> ""

[gstib]

Feels kind of odd.
What's the context where nil is undesirable but "" string might be legitimate? Do you have an example of how you might use this?

[patrobinson]

nil is only possible if you do not set the Environment variable. Any empty string is only possible if you explicitly set it to an empty string. In that case we should trust the user knows what they are doing and did this on purpose.

[gstib]

@stevehodgkiss what are you're thoughts on this. Should it be allowed?

[stevehodgkiss]

I think an empty string is a valid input we should support. We could check ENV.key?(value) or environment_variable.nil? as @patrobinson mentioned.

[stevehodgkiss]

Indentation is off...

[patrobinson]

Thanks!