Bump base to nightly-124154a8; vendor vllm#50693 to lift the #50298 pin - #40
Merged
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fank
marked this pull request as ready for review
August 1, 2026 20:46
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump the base from
nightly-6f91edf9(07-29) tonightly-124154a8(08-01) and vendor vllm#50693, which lifts the reason we were pinned.Why the pin existed, and why it can go
PR #38 pinned us one nightly below vllm#50298, because that PR's warmup branch in
models/deepseek_v4/nvidia/flashmla.pyassertsself.topk_indices_buffer is not None. A DSpark drafter has no indexer buffer, soprofile_rundied with a bareAssertionErrorafter the full ~32 min weight load — reported as vllm#50615.vllm#50693 (opened 08-01, fixes #50615) makes the assert conditional:
Verified that this actually covers our checkpoint, which was the open question in #50615's own text — the fix only helps if the drafter is SWA-only.
DeepSeek-V4-Flash-0731'scompress_ratioshas 46 entries for 43 hidden layers, and the trailing three (the MTP/DSpark layers) are0. Sinceswa_only = compress_ratio <= 1, our draft layers take the fixed branch. A checkpoint whose draft layers compress would still trip it; that caveat is now in the Dockerfile comment.What the bump buys
Also resets the nightly prune clock: only ~10 nightlies are retained (currently back to 07-23), so
6f91edf9expires around mid-August.Verification
124154a8is a strict superset of the current pin —git merge-base --is-ancestor 6f91edf96 124154a8passes (166 commits ahead), so this is not a release-branch-cut trapgit apply --check -p1clean against124154a8: the four existing ones plus #50693Tripwire rewritten, not deleted
The old tripwire asserted that the warmup branch contains no assert on
topk_indices_buffer. That is now the wrong invariant — post-#50693 the assert is expected, it just has to sit behind theswa_onlyguard. The new check asserts ordering:Confirmed it discriminates — run against
124154a8before and after applying the patch:A tripwire that passes on both states would be decoration; this one was tested against both.
Not addressed here
_any_tool_strictstill gates the structural tag behind at least onestrict: truetool, and pi sendsstrict: false, so DSML generation stays unconstrained.?-stalls).reasoning_effort: "high"is still a no-op on this SHA; only"max"injects anything.Cost
Five vendored patches, all against open PRs, on a base that expires in ~2 weeks. Each bump means re-verifying five patches and four tripwires. The real exit is the next stable release, which would carry #48993/#48317/#48957 and be a tag — this buys performance and time, not an escape from the cycle.