fix invalid handling of WindowsError on python 3 - #187
Merged
Conversation
LeonarddeR
changed the title
Author
|
I'm happy to revert the 'as', no problem at all.
|
feerrenrut
pushed a commit
to nvaccess/nvda
that referenced
this pull request
Jul 19, 2019
In outlook and powerpoint, we create a waiting for xx window while pumping com events. However, comtypes.client.PumpEvents now always raises an error due to a bug in comtypes, see enthought/comtypes#187 Until the bug is fixed in comtypes, this will also log a debug warning for time outs, though that's not very problematic IMO. Fixes #9921
Author
|
@vasily-v-ryabov: Your request has been applied. |
This was referenced Mar 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes comtypes._comobj.winerror by no longer subscripting the exception. This pull requests makes this function use instance checking instead, raising a TypeError when the instance is neither COMError nor WindowsError.
Fixes #186
It also fixes comtypes.client.PumpEvents raising RPC_S_CALLPENDING.