E2E test fixing and bring back reports #9238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
added
CI: Clean build required
farmaazon
requested review from
PabloBuchu,
indiv0,
somebody1234,
Frizi,
MichaelMauderer,
vitvakatu,
kazcw and
mwu-tow
as code owners
mwu-tow
approved these changes
Mar 4, 2024
Frizi
approved these changes
Mar 4, 2024
app/gui2/eslint.config.js
Outdated
| @@ -50,6 +57,16 @@ const conf = [ | |||
| 'vue/multi-word-component-names': 0, | |||
| }, | |||
| }, | |||
| // We must make sure our E2E tests await all steps, otherwise they're flacky. | |||
app/gui2/playwright.config.ts
Outdated
| trace: 'on-first-retry', | ||
| // We have a problem with many transient failures; to investigate them, we need trace on all | ||
| // tests. | ||
| trace: 'on', |
There was a problem hiding this comment.
Could this be retain-on-first-failure?
Comment on lines
+86
to
+87
| .instrument(span) | ||
| .boxed() |
There was a problem hiding this comment.
Why .boxed() instead of .await? Also, this whole change could probably be an #[instrument] annotation instead.
There was a problem hiding this comment.
This is a convention to avoid unnecessary lifetime dependencies on futures — we don't want to force caller to keep arguments alive while the artifacts are uploading. To avoid spurious lifetime dependencies we avoid using async fn here, which in turn makes it impossible to use #[instrument].
somebody1234
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
After investigating some errors, I found another two missing awaits in our tests. Because those are so easy to overlook, I added a lint rule which makes failure on unhandled promise (for e2e tests only).
Also, enabled HTML reports again, with traces this time, to enable closer investigation of any failure in the future. @mwu-tow added code for uploading them in GH.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] Unit tests have been written where possible.[ ] If GUI codebase was changed, the GUI was tested when built using./run ide build.