Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The user should be able to have the headers Inferred when reading a Delimited file #3472

Merged
merged 7 commits into from
May 25, 2022
Merged

The user should be able to have the headers Inferred when reading a Delimited file #3472

merged 7 commits into from
May 25, 2022

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented May 23, 2022 •
edited
Loading

Pull Request Description

Implements https://www.pivotaltracker.com/story/show/181986831

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run.sh ide dist and ./run.sh ide watch.

@radeusgd radeusgd marked this pull request as ready for review May 23, 2022 16:34
@radeusgd radeusgd self-assigned this May 23, 2022
jdunkerley
jdunkerley reviewed May 24, 2022
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to think on but generally happy

std-bits/table/src/main/java/org/enso/table/read/CellTypeGuesser.java Outdated Show resolved Hide resolved
std-bits/table/src/main/java/org/enso/table/parsing/BaseTimeParser.java Outdated Show resolved Hide resolved
@radeusgd radeusgd force-pushed the wip/radeusgd/delimited-parse-182200028 branch 2 times, most recently from db79e8f to c9d7d60 Compare May 24, 2022 12:44
@radeusgd radeusgd force-pushed the wip/radeusgd/delimited-infer-headers-181986831 branch 2 times, most recently from f0251ad to 4bf8dd6 Compare May 24, 2022 12:58
@radeusgd radeusgd force-pushed the wip/radeusgd/delimited-parse-182200028 branch from 95d37af to efc7e0e Compare May 24, 2022 14:02
@radeusgd radeusgd force-pushed the wip/radeusgd/delimited-infer-headers-181986831 branch from 4bf8dd6 to 8ef75e0 Compare May 24, 2022 14:02
Base automatically changed from wip/radeusgd/delimited-parse-182200028 to develop May 24, 2022 15:59
@radeusgd radeusgd force-pushed the wip/radeusgd/delimited-infer-headers-181986831 branch 2 times, most recently from f1f142c to 150571c Compare May 25, 2022 09:31
@radeusgd radeusgd force-pushed the wip/radeusgd/delimited-infer-headers-181986831 branch from 150571c to 5c40488 Compare May 25, 2022 09:41
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label May 25, 2022
@mergify mergify bot merged commit 7f572bf into develop May 25, 2022
@mergify mergify bot deleted the wip/radeusgd/delimited-infer-headers-181986831 branch May 25, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertp hubertp hubertp approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@4e6 4e6 Awaiting requested review from 4e6

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach

Assignees

@radeusgd radeusgd

Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radeusgd @hubertp @jdunkerley