Automatically force all-defaulted functions #3414
Conversation
| | foo f = f 1 | ||
| | bar x=1 = x + 1 | ||
| | foo (bar ...) |
There was a problem hiding this comment.
Minor nitpick but I'd suggest making the argument passed to f have different value than the default one - this way we ensure that we do not get some weird behaviour where the default one was used instead (it seems extremely unlikely to get a bug with such behaviour, but you never know and the cost of testing this case is 0 as we just need to change this value).
There was a problem hiding this comment.
Good point, I wouldn't call it "extremely unlikely" given the behavior I saw in the process of implementing this, and I would call the test as it exists "extremely bad at testing things" :P
| limit = Constants.CacheSizes.THUNK_EXECUTOR_NODE) | ||
| Stateful doCached( | ||
| Thunk thunk, | ||
| Function thunk, |
There was a problem hiding this comment.
Nit pick: does the variable still deserve name thunk when it's type is now Function?
There was a problem hiding this comment.
I agree that thunk.isThunk is a bit confusing :)
|
|
||
| @Specialization( | ||
| guards = {"!fn.isThunk()", "fn.isFullyApplied()", "isTail == cachedIsTail"}, | ||
| limit = "3" /* limit is 3 because that's the number of different values for isTail */) |
There was a problem hiding this comment.
One could define
static int numberOfDifferentValuesForIsTail() {
return BaseNode.TailStatus.values().length;
}and then use
| limit = "3" /* limit is 3 because that's the number of different values for isTail */) | |
| limit = "numberOfDifferentValuesForIsTail()" |
engine/runtime/src/main/java/org/enso/interpreter/runtime/callable/argument/Thunk.java
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/callable/function/FunctionSchema.java
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/callable/function/FunctionSchema.java
Outdated
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/type/Types.java
Show resolved
Hide resolved
...me/src/main/java/org/enso/interpreter/node/callable/argument/IndirectArgumentSorterNode.java
Show resolved
Hide resolved
| val dependencies = depInfo.dependencies | ||
|
|
||
| // The test for dependents | ||
| dependents.getDirect(argXId) shouldEqual Some(Set(xUseId)) |
There was a problem hiding this comment.
Out of curiosity: Why the changes in this test have to be made? Is it because of changes in DemandAnalysis?
There was a problem hiding this comment.
Yes, it's a horrible terrible spec and honestly I had to stop myself nuking the whole file. So the problem here is, these stupid pass specs use previous passes to build the initial test state. So, demand analysis runs before this, so the input IR for this spec changes and now it blows up. We should discuss this, but IMO in the near future we need to either nuke all of these specs, or rewrite them to be self-sufficient.
There was a problem hiding this comment.
Isn't the IR serializable? If so, we can serialize the input into a file and read it.
engine/runtime/src/test/scala/org/enso/interpreter/test/semantic/CurryingTest.scala
Show resolved
Hide resolved
engine/runtime/src/main/scala/org/enso/compiler/codegen/IrToTruffle.scala
Outdated
Show resolved
Hide resolved
engine/runtime/src/main/scala/org/enso/compiler/codegen/IrToTruffle.scala
Outdated
Show resolved
Hide resolved
| limit = Constants.CacheSizes.THUNK_EXECUTOR_NODE) | ||
| Stateful doCached( | ||
| Thunk thunk, | ||
| Function thunk, |
There was a problem hiding this comment.
I agree that thunk.isThunk is a bit confusing :)
…uffle.scala Co-authored-by: Hubert Plociniczak <[email protected]>
|
Reviewed again. Looks sane. |
Pull Request Description
This changes the interpreter to treat functions with all-defaulted args as thunks. Seems to have no performance impact in compiled code.
Important Notes
Checklist
Please include the following checklist in your PR:
./run distand./run watch.