Opening Component Browser by clicking on the output port #3346

akavel · 2022-03-17T16:54:14Z

Pull Request Description

Double-clicking a node's output port or clicking the port with a right mouse button (RMB) creates a new node aligned to the clicked node.

Visuals

The screencast below demonstrates the following features:

double-clicking the left mouse button on a node's output port;
clicking the right mouse button on a node's output port;
alignment of the nodes created as a result of the actions described above;
corner case: double-clicking (and RMB-clicking) on output ports of a "collapsed" ("enterable") node;
double-clicking on a "collapsed" ("enterable") node still allows entering the node when done over an area of the node that is not the node's output port;
basic support for nodes with multiple output ports (shown on the interface demo scene).

Screen.Recording.2022-03-17.at.17.02.58.mov

The supplementary screencast below demonstrates that double-clicking or RMB-clicking a node's output port cancels the action of dragging a new connection from a node.

Screen.Recording.2022-03-18.at.12.48.38.mov

https://www.pivotaltracker.com/story/show/181076145

Important Notes

The "double-clicking a node" shortcut was previously used to allow entering a "collapsed" node (for example, a node created by pressing the cmd+g keyboard shortcut after selecting a group of nodes). This PR keeps that functionality when the user double-clicks on a node, as long as the mouse is not positioned over the node's output ports.
The support for nodes with multiple output ports is currently very basic. The information about a port (Crumb) is passed into the create_node function, but it is not passed further to NodeSource. The Node Searcher currently does not support passing port information through NodeSource.

Checklist

Please include the following checklist in your PR:

The documentation has been updated if necessary.
All code conforms to the Scala, Java, and Rust style guides.
All code has been tested:
- Unit tests have been written where possible.
- If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

…ement-by-dblclick-181076145

wdanilo · 2022-03-18T12:02:23Z

app/gui/view/graph-editor/src/lib.rs

-#[derive(Clone, Copy, Debug)]
+#[derive(Clone, Debug)]


What is the reason to make this struct so heavyweight? Why do you need to keep EdgeEndpoint instead of NodeId, just like DroppingEdge does?

It was by my request. If we want to support multiple output ports (and we want eventually), then the future implementor would already know where to start.

I am OK with adding the information. My question was why instead of adding simply NodeId we are adding the whole structure there.

Because it makes sense in this structure. The node was created by clicking on the port - the fact that we don't make use of this information right now is an implementation detail. And I would not be worried with weight of crumbs: those Vecs are empty in most cases, and usually have no more than two elements otherwise.

farmaazon · 2022-03-18T12:02:36Z

app/gui/view/graph-editor/src/lib.rs

@@ -2831,7 +2848,7 @@ fn new_graph_editor(app: &Application) -> GraphEditor {
                input_press    : &node_input_touch.down,
                output         : &out,
            };
-            model.create_node(&ctx, *way, *mouse_pos)
+            model.create_node(&ctx, way.clone(), *mouse_pos)


Perhaps create_node could take way by a reference?

farmaazon · 2022-03-18T12:08:02Z

app/gui/view/graph-editor/src/lib.rs

+        input_start_node_creation_from_port <- inputs.hover_node_output.sample(&inputs.start_node_creation_from_port);
+        start_node_creation_from_port <- input_start_node_creation_from_port.filter_map(|v| v.clone());
+        start_creation_from_port_way <- start_node_creation_from_port.map(
+            |endpoint| WayOfCreatingNode::StartCreationFromPortEvent{endpoint: endpoint.clone()});
+        removed_edges_on_node_creation_from_port <= start_creation_from_port_way.map(f_!(model.model.clear_all_detached_edges()));
+        out.source.on_edge_drop <+ removed_edges_on_node_creation_from_port;


Some of those lines are over 100 characters.

In this section, FRP nodes are for just creating the way structure. Please move nodes specific to creating node from clicking output to a separate block.

farmaazon · 2022-03-18T12:23:27Z

app/gui/view/graph-editor/src/lib.rs

+        /// Start creation of a new Node connected to the port that is currently under the cursor.
+        /// If the cursor is currently not over any node's port, this event will have no effect.


I would repeat or refer to information in start_node_creation that this is meant to be user interaction.

…lines at 100 cols.

akavel · 2022-03-18T14:57:10Z

(Process note: the code-review is now Approved, therefore the PR is waiting for an Acceptance/QA Review on Task https://www.pivotaltracker.com/story/show/181076145 before merge.)

Opening Component Browser by clicking on the output port - Pivotal Tracker

…6145

vitvakatu

Accepted

akavel added 30 commits March 9, 2022 11:25

DEBUG hover_node_output

df9cfec

WIP shortcuts & endpoint for start_conn_node_creation

34be876

WIP start a new Way

619bb8b

WIP connecting hover_node_output

4ab1ab5

WIP handling the event

684af0b

fix

8f147dd

DEBUG create_node way

be088fe

TODO gate maybe

39661f6

DEBUG hover_out_port in create_node()

62c5884

WIP some_node_output_hovered (bool)

7133e36

WIP enter_node <- .gate_not(some_node_output_hovered)

c7af4fc

DEBUG node_to_enter

55de185

start_connected_creation_way .gate(some_node_output_hovered)

f2038fd

CLEANUP use out.xyz instead of out.source.xyz

ab86caa

run clear_all_detached_edges()

a830521

Merge remote-tracking branch 'origin/develop' into wip/akavel/cb-plac…

4ccbd8f

…ement-by-dblclick-181076145

CLEANUP mcdbg1/2

a54faa5

doc for enum

d3aaec6

hovered_endpoint

8a7ce64

WIP fff = Way { endpoint }

0589a04

del hover_out_port

dc755a9

aaa, bbb, fff

4e2c142

WIP cleanup & names changing

04e1402

more rename

a246f22

create under endpoint, not under source_node

54e8311

CLEANUP some DEBUGs

bfad086

on_connected -> on_from_port

c8d0f70

CLEANUP traces

21b83a8

cargo fmt

ebc99fb

Merge remote-tracking branch 'origin/develop' into wip/akavel/cb-plac…

ba9986d

…ement-by-dblclick-181076145

akavel added 2 commits March 18, 2022 10:46

changelog

7bade59

output_port_is_hovered need not be public endpoint

05d243b

akavel marked this pull request as ready for review March 18, 2022 11:55

akavel requested review from MichaelMauderer, wdanilo and farmaazon as code owners March 18, 2022 11:55

wdanilo requested changes Mar 18, 2022

View reviewed changes

farmaazon approved these changes Mar 18, 2022

View reviewed changes

akavel added 3 commits March 18, 2022 14:45

review: move start_creation_from_port to separate code block & split …

dc2a75d

…lines at 100 cols.

review: pass way to create_node by reference

b092f91

review: mention user interaction in endpoint comment

6309050

akavel requested a review from wdanilo March 18, 2022 14:39

wdanilo approved these changes Mar 18, 2022

View reviewed changes

akavel and others added 3 commits March 18, 2022 15:57

Merge branch 'develop' into wip/akavel/cb-placement-by-dblclick-18107…

0e81dc5

…6145

Implement integration test for adding node by output port click

50eed5d

Merge branch 'develop' into wip/akavel/cb-placement-by-dblclick-18107…

bffa49c

…6145

vitvakatu approved these changes Mar 21, 2022

View reviewed changes

akavel added the CI: Ready to merge This PR is eligible for automatic merge label Mar 21, 2022

mergify bot merged commit b117a7d into develop Mar 21, 2022

mergify bot deleted the wip/akavel/cb-placement-by-dblclick-181076145 branch March 21, 2022 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Opening Component Browser by clicking on the output port #3346

Opening Component Browser by clicking on the output port #3346

akavel commented Mar 17, 2022 •

edited

Loading

wdanilo Mar 18, 2022

farmaazon Mar 18, 2022

wdanilo Mar 18, 2022

farmaazon Mar 18, 2022

farmaazon Mar 18, 2022

farmaazon Mar 18, 2022

farmaazon Mar 18, 2022

akavel commented Mar 18, 2022 •

edited by unfurl-links bot

Loading

vitvakatu left a comment

		/// Start creation of a new Node connected to the port that is currently under the cursor.
		/// If the cursor is currently not over any node's port, this event will have no effect.

Opening Component Browser by clicking on the output port #3346

Opening Component Browser by clicking on the output port #3346

Conversation

akavel commented Mar 17, 2022 • edited Loading

Pull Request Description

Visuals

Important Notes

Checklist

wdanilo Mar 18, 2022

Choose a reason for hiding this comment

farmaazon Mar 18, 2022

Choose a reason for hiding this comment

wdanilo Mar 18, 2022

Choose a reason for hiding this comment

farmaazon Mar 18, 2022

Choose a reason for hiding this comment

farmaazon Mar 18, 2022

Choose a reason for hiding this comment

farmaazon Mar 18, 2022

Choose a reason for hiding this comment

farmaazon Mar 18, 2022

Choose a reason for hiding this comment

akavel commented Mar 18, 2022 • edited by unfurl-links bot Loading

vitvakatu left a comment

Choose a reason for hiding this comment

akavel commented Mar 17, 2022 •

edited

Loading

akavel commented Mar 18, 2022 •

edited by unfurl-links bot

Loading