Support source maps for JS-based visualizations #3208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitvakatu
requested review from
4e6,
farmaazon,
MichaelMauderer,
mwu-tow and
wdanilo
as code owners
MichaelMauderer
suggested changes
Jan 10, 2022
app/gui/view/graph-editor/src/component/visualization/foreign/java_script/source.rs
Show resolved
Hide resolved
app/gui/view/graph-editor/src/component/visualization/foreign/java_script/source.rs
Outdated
Show resolved
Hide resolved
app/gui/view/graph-editor/src/component/visualization/foreign/java_script/source.rs
Outdated
Show resolved
Hide resolved
app/gui/view/graph-editor/src/component/visualization/foreign/java_script/source.rs
Outdated
Show resolved
Hide resolved
MichaelMauderer
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Continuation of #3204
This PR implements source maps support for JS-based visualizations (both user-defined and built-in). This allows seeing original file names and line numbers in DevTools while debugging errors in visualizations. See attached screen recordings:
Built-in visualizations:
Screen.Recording.2021-12-27.at.19.54.45.mov
User-defined ones:
Screen.Recording.2021-12-27.at.19.55.27.mov
This is implemented by generating and attaching source maps directly to the source code of the visualization using the "inline" base64-encoded source map.
Checklist
Please include the following checklist in your PR: