Test `Standard.Microsoft` in (mocked) dual JVM mode #14037

JaroslavTulach · 2025-09-22T12:27:47Z

Pull Request Description

steps towards Turn Standard.Microsoft into "dual JVM" mode library #13804
modifies CI actions to execute mocked dual JVM mode tests for test/Microsoft_Tests
fixes the code to pass the test
- few more fixes needed to get it working
speed isn't the focus right now
the production mode remains unchanged - one needs to opt-in to run the tests in dual JVM mode

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

All code follows the
Scala,
Java,
Unit tests have been written where possible and they succeed.

distribution/lib/Standard/Microsoft/0.0.0-dev/src/SQLServer_Connection.enso

…oftServerInHotSpot

- While trying to understand the `HideableValue` usages - which is not working fine with #14037 yet - trying to _lower the conceptual scope_ - by encapsulating various `HideableValue` implementations - and exposing only factories and virtual methods on the `HideableValue`

…l_hole_default

distribution/lib/Standard/Microsoft/0.0.0-dev/src/Internal/SQLServer_Dialect.enso

distribution/lib/Standard/Microsoft/0.0.0-dev/src/SQLServer_Connection.enso

JaroslavTulach · 2025-09-28T15:42:17Z

build.sbt

          `std-aws-polyglot-root`.listFiles("*.jar").map(_.getAbsolutePath()) ++
+          `std-microsoft-polyglot-root`
+            .listFiles("*.jar")
+            .map(_.getAbsolutePath()) ++


for now we want to keep building with Standard.Microsoft libraries processed

thus 20529f8 returns it back

@jdunkerley has asked, how to test these changes in the IDE?

once this PR is integrated, then one can opt-in by

running in --jvm mode

turning the mocking on by --vm.D=polyglot.enso.classLoading=Standard.Microsoft:guest,hosted

just pass the options via ENSO_JVM_OPTS and that's it!

since 8af9c47 one can rebuild with ENSO_LAUNCHER=-ms sbt buildEngineDistribution

build_tools/cli/src/lib.rs

.github/workflows/engine-checks.yml

…Factory

distribution/lib/Standard/Database/0.0.0-dev/src/Internal/Result_Set.enso

vitvakatu

CI changes

JaroslavTulach · 2025-10-01T09:01:12Z

there is still a failure in the CI

[FAILED] [SQLServer] Audit Logs: [1/3, 2008ms] ️ 
Error: An unexpected panic was thrown: java.lang.IllegalArgumentException: Access to language 'enso' is not permitted. 
 ️     - [FAILED] should see Database operations performed on a table through the standard workflow [1746ms]
 ️         Reason: An unexpected panic was thrown: java.lang.IllegalArgumentException: Access to language 'enso' is not permitted. 
 ️         at <enso> JDBC_Connection.run_without_autocommit.JDBC_Connection.run_without_autocommit<arg-1>(/runner/_work/enso/enso/built-distribution/enso-engine-2025.3.1-dev-linux-amd64/enso-2025.3.1-dev/lib/Standard/Database/2025.3.1-dev/src/Internal/JDBC_Connection.enso:229:39-73)
 ️         at <enso> Resource.bracket(Internal)
 ️         at <enso> JDBC_Connection.run_without_autocommit.JDBC_Connection.run_without_autocommit(/runner/_work/enso/enso/built-distribution/enso-engine-2025.3.1-dev-linux-amd64/enso-2025.3.1-dev/lib/Standard/Database/2025.3.1-dev/src/Internal/JDBC_Connection.enso:229-230)
 ️         at <enso> Managed_Resource.with_builtin(Internal)
 ️         at <enso> Panic.catch(Internal)

so far I haven't reproduced it locally, so I am trying this:

enso$ ENSO_LAUNCHER=test ./run backend build
enso$ ./run backend test std-mock-dual-microsoft

let's see if it finally reproduces... So the reproducer is as simple as:

ENSO_RUN_REAL_CLOUD_TEST=1 ENSO_HTTP_TEST_HTTPBIN_URL=http://localhost:8080 ENSO_SQLSERVER_DATABASE=tempdb "/home/devel/NetBeansProjects/enso/enso/built-distribution/enso-engine-0.0.0-dev-linux-amd64/enso-0.0.0-dev/bin/enso" "--jvm" "--vm.D=polyglot.enso.classLoading=Standard.Microsoft:guest,hosted" "--no-ir-caches" "--run" "/home/devel/NetBeansProjects/enso/enso/test/Microsoft_Tests" Audit

and the problem is in Context.getCurrent() call in CurrentEnsoProject class.

…VM mode

JaroslavTulach · 2025-10-01T15:27:48Z

the problem is in Context.getCurrent() call in CurrentEnsoProject class.

I tried various ways to fix it, but for now I decided to just make the tests pending.

jdunkerley

A few nits but generally looks good

jdunkerley · 2025-10-01T15:44:52Z

distribution/lib/Standard/Base/0.0.0-dev/src/Errors/Common.enso

-        handle t = Panic.catch t handler=(_-> Error.throw (Incomparable_Values.Error Nothing Nothing))
+        handle t = Panic.catch t handler=_->
+            Error.throw (Incomparable_Values.Error Nothing Nothing)


Why change this?

I was trying to place breakpoint on this Error.throw only. With our current tooling, it can only be done when it is on separate line.

distribution/lib/Standard/Database/0.0.0-dev/src/Internal/JDBC_Connection.enso

distribution/lib/Standard/Database/0.0.0-dev/src/Internal/Statement_Setter.enso

distribution/lib/Standard/Microsoft/0.0.0-dev/src/Internal/SQLServer_Dialect.enso

distribution/lib/Standard/Microsoft/0.0.0-dev/src/SQLServer_Connection.enso

distribution/lib/Standard/Table/0.0.0-dev/src/Internal/In_Memory_Table_Implementation.enso

distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Java_Problems.enso

distribution/lib/Standard/Database/0.0.0-dev/src/Internal/JDBC_Connection.enso

enso-bot · 2025-10-02T04:44:32Z

Jaroslav Tulach reports a new STANDUP for yesterday (2025-10-01):

Progress: .

debug Rust CI gen: a32206e#r2393592162
fighting with Audit tests in dual JVM mode: Test Standard.Microsoft in (mocked) dual JVM mode #14037 (comment)
review: avoid special casing: Remove duplicated IR ASTs for static methods #13962 (review)
various meetings It should be finished by 2025-10-05.

Co-authored-by: James Dunkerley <[email protected]>

…enso into wip/jtulach/MicrosoftServerInHotSpot

Co-authored-by: James Dunkerley <[email protected]>

…enso into wip/jtulach/MicrosoftServerInHotSpot

…ment

hubertp

Forgot to click "submit review" so here is a late review.

hubertp · 2025-10-02T09:03:19Z

.vscode/launch.json

+      "type": "lldb",
+      "request": "launch",
+      "preLaunchTask": "Rust Gen CI",
+      "name": "Rust Gen CI",


That sounds like something that could be added to dev docs rather than only be mentioned (and forgotten) in a PR comment.

hubertp · 2025-10-02T09:12:38Z

docs/infrastructure/native-image.md

    image debugger_
  - using `native,-ls` disables support for _language server_ in the generated
    binary
+  - using `native,-ms` **opts-out** for `Standard.Microsoft` library being


the -ms short name is cryptic. Could we use sth with stdlib prefix, say -stdlib-ms or -stdlib-microsoft?

hubertp · 2025-10-02T09:14:03Z

engine/runtime/src/main/java/org/enso/interpreter/runtime/EnsoPolyglotJava.java

      return obj != null
          && iop.hasLanguage(obj)
-          && iop.getLanguage(obj).getSimpleName().equals("OtherLanguage");
+          && iop.getLanguage(obj).getSimpleName().equals("EpbLanguage");


Any chance we could avoid relying on strings to determine that?

enso-bot · 2025-10-03T06:39:46Z

Jaroslav Tulach reports a new STANDUP for yesterday (2025-10-02):

Progress: .

Standard.Microsoft dual JVM tests are in: Test Standard.Microsoft in (mocked) dual JVM mode #14037
benchmarking dual JVM mode: Fibonacci benchmark comparing hosted and dual JVM modes #14099
special static syntax for instance calls with self= https://discord.com/channels/401396655599124480/1421229584963211264/1423273374540496978
revew note on the new syntax: Semi-formal specification for method resolution #13961 (review)
access to Vector.is_empty: Remove duplicated IR ASTs for static methods #13962 (comment) It should be finished by 2025-10-05.

Discord
Discord - Group Chat That’s All Fun & Games
Discord is great for playing games and chilling with friends, or even building a worldwide community. Customize your own space to talk, play, and hang out.

Run Standard.Microsoft in dual JVM mode

531a763

JaroslavTulach self-assigned this Sep 22, 2025

JaroslavTulach requested review from 4e6, AdRiley, Akirathan, GregoryTravis, hubertp and jdunkerley as code owners September 22, 2025 12:27

JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Sep 22, 2025

JaroslavTulach commented Sep 22, 2025

View reviewed changes

distribution/lib/Standard/Microsoft/0.0.0-dev/src/SQLServer_Connection.enso Show resolved Hide resolved

JaroslavTulach commented Sep 22, 2025

View reviewed changes

distribution/lib/Standard/Microsoft/0.0.0-dev/src/SQLServer_Connection.enso Outdated Show resolved Hide resolved

unfurl-links bot mentioned this pull request Sep 23, 2025

Moving >, >=, <, <= to types where such operators make sense #14017

Merged

5 tasks

JaroslavTulach marked this pull request as draft September 23, 2025 02:31

Merge remote-tracking branch 'origin/develop' into wip/jtulach/Micros…

6b1622d

…oftServerInHotSpot

JaroslavTulach mentioned this pull request Sep 24, 2025

Hide implementations of HideableValue #14049

Merged

3 tasks

JaroslavTulach added 3 commits September 25, 2025 05:21

Merging with latest HidableValue changes

c40ad9c

Allow to pass a HideableValue factory from the other JVM

4bbffbd

Allow SQLServer_Dialect to pass its own version of JDBCUtils into fil…

20f573f

…l_hole_default

JaroslavTulach commented Sep 26, 2025

View reviewed changes

distribution/lib/Standard/Microsoft/0.0.0-dev/src/Internal/SQLServer_Dialect.enso Outdated Show resolved Hide resolved

unfurl-links bot mentioned this pull request Sep 27, 2025

Submit PR to POI to remove awt dependency #13983

Closed

JaroslavTulach commented Sep 28, 2025

View reviewed changes

distribution/lib/Standard/Microsoft/0.0.0-dev/src/SQLServer_Connection.enso Show resolved Hide resolved

Merge with origin/develop

d4a1ac7

JaroslavTulach force-pushed the wip/jtulach/MicrosoftServerInHotSpot branch from 2736f70 to d4a1ac7 Compare September 28, 2025 13:33

Running test/Microsoft_Tests in a special - dual JVM mode

20529f8

JaroslavTulach commented Sep 28, 2025

View reviewed changes

build_tools/cli/src/lib.rs Show resolved Hide resolved

JaroslavTulach commented Sep 28, 2025

View reviewed changes

.github/workflows/engine-checks.yml Outdated Show resolved Hide resolved

Derive ProblemAggregator and ColumnFetcher classes from ColumnFetcher…

39e1f0b

…Factory

JaroslavTulach commented Sep 28, 2025

View reviewed changes

distribution/lib/Standard/Database/0.0.0-dev/src/Internal/Result_Set.enso Show resolved Hide resolved

JaroslavTulach added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Oct 1, 2025

vitvakatu approved these changes Oct 1, 2025

View reviewed changes

Avoid Audit tests when Standard.Microsoft tests are running in dual J…

7606734

…VM mode

jdunkerley approved these changes Oct 1, 2025

View reviewed changes

AdRiley reviewed Oct 1, 2025

View reviewed changes

distribution/lib/Standard/Database/0.0.0-dev/src/Internal/JDBC_Connection.enso Show resolved Hide resolved

JaroslavTulach and others added 12 commits October 2, 2025 06:49

Let's name the argument problem_aggregator

5bc3de1

Removing unused polyglot java import

544c8fb

Returning private comment back

623b6bb

Merge with latest develop

c9ce1cb

Provide JDBCUtils as positional argument

22a8d10

Co-authored-by: James Dunkerley <[email protected]>

Call the argument jdbc_utils

6f9c500

Merge branch 'wip/jtulach/MicrosoftServerInHotSpot' of enso:enso-org/…

f908502

…enso into wip/jtulach/MicrosoftServerInHotSpot

Formatting

f460c68

Co-authored-by: James Dunkerley <[email protected]>

Providing sql_exception as a positional argument

fcd4313

Co-authored-by: James Dunkerley <[email protected]>

Merge branch 'wip/jtulach/MicrosoftServerInHotSpot' of enso:enso-org/…

84426cd

…enso into wip/jtulach/MicrosoftServerInHotSpot

Using full sql_exception atom constructor name and removing self argu…

7c289aa

…ment

Adjusting Standard.Database API

a6830b0

JaroslavTulach requested a review from AdRiley October 2, 2025 06:55

4e6 approved these changes Oct 2, 2025

View reviewed changes

Akirathan approved these changes Oct 2, 2025

View reviewed changes

AdRiley approved these changes Oct 2, 2025

View reviewed changes

JaroslavTulach merged commit 9c6a536 into develop Oct 2, 2025
114 of 123 checks passed

JaroslavTulach deleted the wip/jtulach/MicrosoftServerInHotSpot branch October 2, 2025 09:46

hubertp reviewed Oct 2, 2025

View reviewed changes

This was referenced Oct 7, 2025

Initial work on DuckDB #14114

Merged

Run Standard.Google in dual JVM mode #14040

Merged

Test Standard.Microsoft in (mocked) dual JVM mode #14037

Test Standard.Microsoft in (mocked) dual JVM mode #14037

Uh oh!

Conversation

JaroslavTulach commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Description

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JaroslavTulach Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

JaroslavTulach Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vitvakatu left a comment

Choose a reason for hiding this comment

Uh oh!

JaroslavTulach commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JaroslavTulach commented Oct 1, 2025

Uh oh!

jdunkerley left a comment

Choose a reason for hiding this comment

Uh oh!

jdunkerley Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

JaroslavTulach Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

enso-bot bot commented Oct 2, 2025

Uh oh!

Uh oh!

hubertp left a comment

Choose a reason for hiding this comment

Uh oh!

hubertp Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

hubertp Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

hubertp Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

enso-bot bot commented Oct 3, 2025 • edited by unfurl-links bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Test `Standard.Microsoft` in (mocked) dual JVM mode #14037

Test `Standard.Microsoft` in (mocked) dual JVM mode #14037

JaroslavTulach commented Sep 22, 2025 •

edited

Loading

JaroslavTulach Sep 30, 2025 •

edited

Loading

JaroslavTulach commented Oct 1, 2025 •

edited

Loading

enso-bot bot commented Oct 3, 2025 •

edited by unfurl-links bot

Loading