Skip to content

Conversation

@JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Sep 22, 2025

Pull Request Description

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

@JaroslavTulach JaroslavTulach self-assigned this Sep 22, 2025
@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Sep 22, 2025
@JaroslavTulach
Copy link
Member Author

@GregoryTravis, how does one verify everything still works?

@JaroslavTulach
Copy link
Member Author

JaroslavTulach commented Sep 23, 2025

  • the CI seems to be fine
  • however that's probably because no so much code coverage in the tests
  • if this PR affects something, then it would be StravaService
    • the class itself is fine, but it...
    • imports org.enso.base.enso_cloud.ExternalLibraryCredentialHelper
    • and that means the class will be loaded by dual JVMs
  • any advice how to verify StravaService continues to work is welcome!

@JaroslavTulach
Copy link
Member Author

JaroslavTulach commented Sep 23, 2025

  • Could a playwright test be written?
  • Could it click thru the UI and test cloud/strava/engine in an orchestration?

@GregoryTravis
Copy link
Contributor

  • any advice how to verify StravaService continues to work is welcome!

What precisely needs to be verified? That Strava.enso is available, and can successfully call a method in StravaService.java? A stub method would suffice for this. Actual verification of the OAuth process would then not be necessary for this. That test I expect to write later, since it is substantial work. Or, it could be prioritized now. @jdunkerley ?

@JaroslavTulach
Copy link
Member Author

What precisely needs to be verified?

Whether this PR can be integrated or not!

@GregoryTravis
Copy link
Contributor

What precisely needs to be verified?

Whether this PR can be integrated or not!

Again, what needs to be verified?

  • That an Enso project can call Strava.enso?
  • That Strava.enso can call StravaService.java?
  • That StravaService can successfully authenticate with OAuth

If the first two, then you can simply call any method and catch the resulting error. If the third one, then this PR will have to wait.

@GregoryTravis
Copy link
Contributor

  • That an Enso project can call Strava.enso?
  • That Strava.enso can call StravaService.java?
  • That StravaService can successfully authenticate with OAuth

I tested by hand; the first two work, and the third got a error response from the cloud. So, approving.

@JaroslavTulach JaroslavTulach added CI: Ready to merge This PR is eligible for automatic merge CI: Keep up to date Automatically update this PR to the latest develop. labels Sep 26, 2025
@jdunkerley jdunkerley removed the CI: Keep up to date Automatically update this PR to the latest develop. label Sep 26, 2025
@mergify mergify bot merged commit 0763306 into develop Oct 7, 2025
102 of 106 checks passed
@mergify mergify bot deleted the wip/jtulach/StravaNotInNative branch October 7, 2025 05:08
@unfurl-links unfurl-links bot mentioned this pull request Oct 7, 2025
6 tasks
@enso-bot
Copy link

enso-bot bot commented Oct 8, 2025

Jaroslav Tulach reports a new STANDUP for yesterday (2025-10-07):

Progress: .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants