Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with host-based locale and non-native routes #91

Closed
tagliala opened this issue Feb 23, 2015 · 7 comments
Closed

Issue with host-based locale and non-native routes #91

tagliala opened this issue Feb 23, 2015 · 7 comments
Labels
Milestone

Comments

@tagliala
Copy link
Collaborator

Hi,

I noticed that when using the host-based locale option, you are also able to get all the localized routes.

This is a failing test:

  def test_non_native_path
    ## es route on ru com
    host! 'ru.testapp.com'
    get URI.escape('/dummy')
    assert_response :not_found
  end
$ bundle exec ruby -I"lib:test" test/integration/host_locales_test.rb -n /test_non_native_path/
Run options: -n /test_non_native_path/ --seed 21505

# Running:

F

Finished in 0.027698s, 36.1037 runs/s, 36.1037 assertions/s.

  1) Failure:
HostLocalesTest#test_non_native_path [test/integration/host_locales_test.rb:63]:
Expected response to be a <not_found>, but was <200>.
Expected: 404
  Actual: 200

1 runs, 1 assertions, 1 failures, 0 errors, 0 skips

I must dig into this, but if you already know what it's going on please help me

/cc @gi-lunaweb

@tagliala
Copy link
Collaborator Author

tagliala commented Mar 6, 2015

/cc @enriclluelles

@enriclluelles
Copy link
Owner

hey man! real sorry here. New work going on and real busy, will try to take a look today!

@tagliala
Copy link
Collaborator Author

tagliala commented Mar 6, 2015

@enriclluelles don't worry, I'm also very busy so I understand 😞

@tagliala
Copy link
Collaborator Author

tagliala commented Mar 6, 2015

(ps: sorry for the ping)

@tagliala tagliala added the bug label Mar 16, 2015
@tagliala
Copy link
Collaborator Author

https://github.com/enriclluelles/route_translator/tree/fix-native-routes-in-host-locale <-- branch with a failing test. Help would be really appreciated

@rogercampos
Copy link
Contributor

I just saw this issue, I think this solves it #167

@tagliala tagliala modified the milestones: 5.5.0, 6.0.0. Jun 29, 2017
tagliala added a commit that referenced this issue Jul 1, 2017
tagliala added a commit that referenced this issue Jul 1, 2017
@tagliala
Copy link
Collaborator Author

Fixed in the just released 6.0.0.alpha1

tagliala added a commit that referenced this issue Nov 12, 2017
tagliala added a commit that referenced this issue Nov 12, 2017
tagliala added a commit that referenced this issue Dec 3, 2017
tagliala added a commit that referenced this issue Dec 3, 2017
tagliala added a commit that referenced this issue Dec 3, 2017
tagliala added a commit that referenced this issue Dec 3, 2017
tagliala added a commit that referenced this issue Dec 3, 2017
tagliala added a commit that referenced this issue Feb 5, 2018
tagliala added a commit that referenced this issue Apr 9, 2018
tagliala added a commit that referenced this issue Apr 10, 2018
tagliala added a commit that referenced this issue Jun 7, 2018
tagliala added a commit that referenced this issue Oct 3, 2018
tagliala added a commit that referenced this issue Jan 19, 2019
tagliala added a commit that referenced this issue Mar 14, 2019
tagliala added a commit that referenced this issue May 16, 2019
tagliala added a commit that referenced this issue May 16, 2019
tagliala added a commit that referenced this issue Dec 26, 2019
tagliala added a commit that referenced this issue Dec 26, 2019
tagliala added a commit that referenced this issue Dec 26, 2019
tagliala added a commit that referenced this issue Apr 17, 2020
AsgharRaz pushed a commit to AsgharRaz/route_translator that referenced this issue Nov 3, 2020
tagliala added a commit that referenced this issue Jan 13, 2021
tagliala added a commit that referenced this issue Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants