Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow instant publish of modified data fields #10875

Open
wants to merge 6 commits into
base: epic-node-upgrading
Choose a base branch
from

Conversation

vbradnitski
Copy link
Contributor

@vbradnitski vbradnitski linked an issue Jan 28, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 92.52336% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.61%. Comparing base (2b56c4e) to head (1799b35).
Report is 1 commits behind head on epic-node-upgrading.

Files with missing lines Patch % Lines
...com/enonic/xp/repo/impl/node/PatchNodeCommand.java 90.00% 1 Missing and 4 partials ⚠️
...nic/xp/repo/impl/node/NodePermissionsResolver.java 0.00% 1 Missing and 1 partial ⚠️
.../com/enonic/xp/repo/impl/node/NodeServiceImpl.java 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             epic-node-upgrading   #10875      +/-   ##
=========================================================
+ Coverage                  84.60%   84.61%   +0.01%     
- Complexity                 20021    20042      +21     
=========================================================
  Files                       2636     2639       +3     
  Lines                      69568    69675     +107     
  Branches                    5616     5620       +4     
=========================================================
+ Hits                       58856    58955      +99     
- Misses                      7996     7998       +2     
- Partials                    2716     2722       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vbradnitski vbradnitski requested a review from rymsha January 29, 2025 11:04
@vbradnitski vbradnitski marked this pull request as ready for review January 29, 2025 11:04
return results.stream().filter( br -> br.branch.equals( branch ) ).findAny().map( BranchResult::node ).orElse( null );
}

public record BranchResult(Branch branch, Node node)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@vbradnitski vbradnitski changed the base branch from master to epic-node-upgrading January 29, 2025 14:36
@vbradnitski vbradnitski requested a review from rymsha January 29, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow instant publish of modified data fields
3 participants