Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lib i18n must not allow to provide application to read resources #10417

Open
anatol-sialitski opened this issue Feb 13, 2024 · 1 comment
Open

Lib i18n must not allow to provide application to read resources #10417

anatol-sialitski opened this issue Feb 13, 2024 · 1 comment
Assignees
@anatol-sialitski
Labels
Bug
Milestone
8.0.0

Comments

@anatol-sialitski
Copy link
Contributor

anatol-sialitski commented Feb 13, 2024 •
edited
Loading

Lib i18n must not allow to provide application to read resources
@anatol-sialitski anatol-sialitski self-assigned this Feb 13, 2024
anatol-sialitski added a commit that referenced this issue Feb 13, 2024
@anatol-sialitski
Lib i18n must allow to specify application to read resources #10417
dfe1683
@rymsha
Copy link
Contributor

rymsha commented Feb 14, 2024 •
edited
Loading

For similar reasons like in #10419 (comment) we will make an opposite change: remove applicationKey argument from localize method.

  • it is not a good idea to read localization messages from an app which is not even guaranteed to exist at the time localization is done (remember, there is no startup order)

it is a breaking change and will only be done in XP8

@anatol-sialitski anatol-sialitski changed the title Lib i18n must allow to specify application to read resources Lib i18n must does not allow to provide application to read resources Feb 15, 2024
@anatol-sialitski anatol-sialitski changed the title Lib i18n must does not allow to provide application to read resources Lib i18n must not allow to provide application to read resources Feb 15, 2024
@rymsha rymsha added this to the 8.0.0 milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anatol-sialitski anatol-sialitski

Labels
Bug
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
2 participants
@rymsha @anatol-sialitski