chore: Bump Nixpkgs from 25.05 to unstable, and use bazel_8 instead of bazelisk#1763
Conversation
…f bazelisk This is only a 1st step; do note how both the bazelisk package and the .bazelversion has not been removed, and is still required, because various scripts have not been cleaned-up, yet.
Summary of ChangesHello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant update to the project's Nix environment by bumping the Nixpkgs channel from the stable "nixos-25.05" to the "nixos-unstable" branch. Concurrently, it begins the process of migrating the Bazel build system from relying on "bazelisk" to directly utilizing the "bazel_8" package. This change is explicitly marked as an initial phase, with subsequent work planned to fully deprecate and remove "bazelisk" from the project's configuration and scripts. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates Nixpkgs from version 25.05 to unstable and initiates the transition from bazelisk to bazel_8. The changes are clear and align with the description, which correctly states this is an initial step. The move to nixos-unstable is a significant change that provides access to newer packages, and the use of a lock file ensures builds remain reproducible. I have one suggestion to improve the traceability of the new TODO comment.
This is only a 1st step; do note how both the
bazeliskpackage and the.bazelversionhave not been removed, yet.Unfortunately they are still required, for now - because various scripts have not been cleaned-up, yet. Contributions welcome!
Relates to #1709 and (indirectly) also #1730 etc.
@dotdoom FYI