Skip to content

deps: Update protobuf from 32.0 to 32.1#1752

Closed
vorburger wants to merge 1 commit intoenola-dev:mainfrom
vorburger:bump-protobuf-32.1
Closed

deps: Update protobuf from 32.0 to 32.1#1752
vorburger wants to merge 1 commit intoenola-dev:mainfrom
vorburger:bump-protobuf-32.1

Conversation

@vorburger
Copy link
Member

Relates to #1728 (and #1689).

@vorburger vorburger enabled auto-merge (rebase) September 15, 2025 01:19
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a routine dependency update, specifically upgrading the protobuf library to its latest minor version, 32.1. This ensures the project benefits from the most recent bug fixes and improvements in protobuf, maintaining the codebase's health and compatibility with modern standards. The changes involve updating the version declaration in the Bazel module configuration and refreshing the corresponding lock file entries.

Highlights

  • Protobuf Version Update: The protobuf dependency has been updated from version 32.0 to 32.1.
  • Bazel Module Configuration: The MODULE.bazel file was modified to reflect the new protobuf version.
  • Dependency Lock File Update: The MODULE.bazel.lock file was updated with the correct module and source hashes for protobuf version 32.1.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the protobuf bazel dependency from version 32.0 to 32.1. While this change is minor, my review identified a critical issue regarding a version mismatch in your Protobuf dependencies. The protoc compiler version and the protobuf-java runtime library version are significantly out of sync, which could lead to runtime errors. I've added a detailed comment explaining the issue and suggesting a path to resolve it.


# https://github.com/protocolbuffers/protobuf/tree/main?tab=readme-ov-file#bazel-with-bzlmod
bazel_dep(name = "protobuf", version = "32.0")
bazel_dep(name = "protobuf", version = "32.1")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This update to protobuf's bazel dependency from 32.0 to 32.1 is a minor change, but it highlights a larger potential issue with Protobuf versioning in this project.

There appears to be a significant version mismatch between the protoc compiler and the protobuf-java runtime library:

  • protoc compiler version: The bazel_dep for protobuf (which is a facade for rules_proto) and grpc-java both depend on protoc version 27.1 (via rules_proto@7.1.0).
  • protobuf-java runtime version: Your maven.install block pins protobuf-java and protobuf-java-util to version 4.32.0 (lines 101-102).

The rules_jvm_external dependency resolver will likely use version 4.32.0 for the Java runtime, as it's the highest version specified.

This setup is risky because Protobuf does not guarantee compatibility between generated code from an older protoc (27.1) and a much newer runtime library (4.32.0). This can lead to subtle runtime bugs or crashes. The recommended practice is to keep the protoc compiler and the runtime libraries at the same version.

Additionally, protobuf-java:4.32.0 does not appear to be a publicly released version, which might indicate a typo. The latest public version compatible with protoc 27.x is in the 4.27.x range (e.g., 4.27.2).

To resolve this, I recommend aligning the protobuf-java version in your maven.install block with the version expected by your other dependencies (4.27.1 or a compatible version like 4.27.2).

@vorburger
Copy link
Member Author

@claude hi, can you propose how to fix the build failure of this PR?

@vorburger
Copy link
Member Author

With #1759, this is now moot. Yay!

@vorburger vorburger closed this Sep 20, 2025
auto-merge was automatically disabled September 20, 2025 15:19

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant