Skip to content

Conversation

envomer
Copy link
Contributor

@envomer envomer commented Jul 9, 2021

This PR resolves an issue with the conflicting Laravel resolve global function and fixes some object checking using the property_exists instead of array_key_exists function since it doesn't support objects anymore in later PHP versions.

There are more places that use array_key_exists that need to be adjusted to fully support all features of this great library with newer PHP versions. Once I have some time I'll tend to them and create another PR.

But anyways. Let me know what you think.

One last thing. Really great package and superb idea. Loving it so much. Now all the email templates that we use across the platform are structured in a cleaner manner and are easier to maintain.

@simonrepp simonrepp merged commit 70cf0a6 into eno-lang:main Jul 11, 2021
@simonrepp
Copy link
Member

Hey that's a very cool PR, and much appreciated!

I thought I'd just run the test suite and release a patch including your changes but in doing so noticed that in the time since I last had the project open quite a bit more (at least stuff related to the tests) has broken by itself :) (or, respectively, myself being a layman in php I probably just didn't code many things in an ideal way to begin with, so they were destined to break at some point I guess).

If it's helpful to you I can already release the current state anyway (some problems fixed is still better than no problems fixed ;)), but if there's no hurry I'll wait a bit until either you or I find some time to look into more of the stuff to then release a fully working, tested 2021 update.

In any case thanks a lot for your support and the kind words, made my day!

@envomer
Copy link
Contributor Author

envomer commented Jul 11, 2021

Hey Simon.

Well your package deserves all the love there is. Loving the syntax and simplicity. You thoroughly planned out the features and there are so many parts i haven't even tried out yet. Also great documentation and super easy to get started. Thank god i came across eno-lang in my desperate time for a file format that supports a clean and concise file structure for our emails.

Back to your question. There's no hurry from my side at all. As a quick fix i can use the forked version for now and as soon as i worked off my queued tasks (probably a few weeks), i'll invest some time to create a PR that fixes outdated PHP functions, make the code PSR compliant and make the tests pass again.

Again. Great package. I like it a lot and investing time on it, is time well spent. 🚀

envomer added a commit to envomer/enophp that referenced this pull request Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants