Add support for providing notification options #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to pass in a array of
UNAuthorizationOptionsorUIUserNotificationTypeto give to the system during the notification permission request. I needed to add this because I need to specify that I support the new iOS 12 app notifications deep link as well as iOS 12 critical alerts.I noticed you (@ennioma) increased the deployment target to iOS 12 and saw your comment about being unable to support iOS 9 and iOS 10+ in the same project at this time. For that reason i'd also suggest removing the UIApplication notification code in this file before merging the iOS12 branch into master.