Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --term-args command line argument #119

Closed
wants to merge 1 commit into from

Conversation

sbogomolov
Copy link

@sbogomolov sbogomolov commented May 12, 2021

Some terminal emulators (like foot) do not support an argument -e. With --term-args it is possible to customize the arguments passed to the terminal emulator. If this option is not provided -e is used by default to maintain backwards compatibility.

In case of foot we would use it like this:

--term="foot" --term-args=""

Some terminal emulators (like foot) do not support '-e' argument. With
--term-args it is possible to customize the arguments passed to the
terminal emulator. In case of foot we would pass:
  --term-args=''
@electrickite
Copy link
Contributor

This feature would be extremely helpful. Having more flexibility in how the terminal emulator is invoked would allow a wider range of terminals and help work around various WM issues.

@craigbarnes
Copy link

Some terminal emulators (like foot) do not support an argument -e

FWIW, foot now ignores the -e flag.

@meator
Copy link
Collaborator

meator commented May 5, 2024

Thanks for the contribution!

I'm all in for adding more customization, but as craigbarnes has mentioned, foot now supports -e, which makes this PR unnecessary for foot users.

Pretty much all terminals I know of support -e.

@meator
Copy link
Collaborator

meator commented Jun 26, 2024

I have implemented a comprehensive system for --term execution. It should be included in the r3.1 release. See the manpage in develop for more info (see the TERM MODE section).

One of the main reasons I've implemented it is because the -e flag of gnome-terminal is now deprecated. The previous system would stop working for gnome-terminal once it removes the -e flag. The new --term-mode flag includes few presets for often used terminal emulators including gnome-terminal and kitty (kitty and foot use the same commandline arguments to execute things, so they are interchangeable). If you want to execute foot without -e, you can now do:

j4-dmenu-desktop --term-mode=kitty --term=foot

Many terminal emulators provide -e and -x which have similar function but different semantics. The new system acknowledges these changes.

This new system obsoletes the changes in this PR, so I'll close it.

I am still not 100% decided on whether this feature should be a part of j4-dmenu-desktop. I might still revert it

@meator meator closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants