Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add GCS support #231

Merged
merged 1 commit into from
Oct 18, 2024
Merged

feat: add GCS support #231

merged 1 commit into from
Oct 18, 2024

Conversation

Shabablinchikow
Copy link
Contributor

• added GCS support with service account key
• upgraded version of registry (2.8.2 doesn't have GCS plugin =/)
• added basic docs for GCS support

@Shabablinchikow Shabablinchikow changed the title add GCS support feat: add GCS support Dec 18, 2023
@paullaffitte
Copy link
Contributor

paullaffitte commented Dec 27, 2023 •
edited
Loading

Thanks for your contribution! It is not our first priority and we need to setup a test environment to validate your work so it will be done but not very soon.

@Xanadjin
Copy link

@Shabablinchikow @paullaffitte - it would be great if merge conflicts could be resolved and get this into released version of kuik 👍

@Shabablinchikow
Copy link
Contributor Author

Fixed conflicts

@paullaffitte
Copy link
Contributor

Sorry for the late reply, we had other priority that we had to handle on this project as well as on other ones. I reviewed and tested your code and it works as expected! Thanks for you great work. However your commits doesn't follow conventional commit spec, could you update please so we can merge?

@paullaffitte paullaffitte self-assigned this Oct 18, 2024
@Shabablinchikow Shabablinchikow requested a review from a team as a code owner October 18, 2024 10:59
@Shabablinchikow
Copy link
Contributor Author

fixed commit message and re-rebased branch

@paullaffitte
Copy link
Contributor

Amazing! Thanks for your quick reply! I'll merge it right now.

PS: I see that you set the registry tag to 2.8.3, we prefer to not lock the patch level so the latest patch level is used by default. I will change that in an another commit after merging.

@paullaffitte paullaffitte merged commit 9677d44 into enix:main Oct 18, 2024
3 of 4 checks passed
@monkeynator
Copy link
Member

🎉 This PR is included in version 1.11.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paullaffitte paullaffitte paullaffitte left review comments

@erbriones erbriones erbriones left review comments

Assignees

@paullaffitte paullaffitte

Labels
released on @main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Shabablinchikow @paullaffitte @Xanadjin @monkeynator @erbriones