fix(web): preserve file tree expansion state across reloads - #61
Merged
Conversation
Reloading files re-ran resetPaths (a refresh yields a new entries array even when paths are unchanged), which re-applied initialExpansion and blew away the user's expand/collapse state. Compare tree paths by value so resetPaths only runs when the file list actually changes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Reloading/refreshing the files in the file browser auto-expanded the file tree, wiping out the user's current expand/collapse state.
Root cause
The effect that syncs file data into the tree guarded with a reference-equality check (
previousTreePathsRef.current === treePaths). A refresh (useAtomRefresh) yields a brand-newentriesarray even when the file list is identical, sotreePathswas always a new reference. The guard never short-circuited, somodel.resetPaths(treePaths)ran on every reload — andresetPathsre-appliesinitialExpansion: 1, re-expanding collapsed folders and resetting the collapse toggle.Fix
Compare
treePathsby value instead of by reference. When the reloaded paths are identical, the effect updates its refs but skipsresetPaths, leaving the tree's expansion state untouched.resetPathsstill runs when the file list actually changes (files added/removed/renamed).🤖 Generated with Claude Code