fix(web): keep the last diff file reachable with word wrap - #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Adjust diff panel virtualization in word-wrap mode to render bounded chunks around the viewport, allowing wrapped rows to be measured accurately and keeping the final file's content reachable. Scroll mode retains its existing minimal chunk size.
Why
Long wrapped lines can occupy multiple visual rows, but estimating each off-screen line at a single row underestimates the total scroll height. This caused the scrollbar to reach the bottom before the tail of the last diff file was accessible. Measuring larger chunks lets the virtualizer extend the scroll range correctly.
UI Changes
This fixes scrolling behavior in the web diff panel when word wrap is enabled. No screenshots or video included because the change corrects an existing scrolling bug without introducing a new visual design or animation.
Checklist