-
Hi! First, let me add my thanks to everyone else's for the great project! For background, #333 is a problem for me and I'm not entirely happy with the custom As a first step, I've added a number of tests to document the existing behaviour of how errors are transported from the StoryAs a developer who forked the repo, I want to know how to discuss contributing my changes back upstream, So that others users of the project can benefit. Acceptance criteria
|
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 9 replies
-
Hey there, thanks for the contribution interest! Regarding #333, it is an issue with graphql-js and not graphql-ws itself. See graphql/graphql-js#1539 and graphql/graphql-js#4001. Also, the reason why graphql-ws doesn't offer built-in handling of internal errors is because there's no one-glove-fits-all. Errors are important and should be handled with care, exactly to the needs of the user - not the library author. Regarding contributions, aside from what's stated in the contributing doc, I have no preference. You're free to open a PR or an issue, or both. IMHO, if you have a PR handy, I don't think there's a need to additionally have an issue open. All the necessary discussion can take place there. |
Beta Was this translation helpful? Give feedback.
Hey there, thanks for the contribution interest!
Regarding #333, it is an issue with graphql-js and not graphql-ws itself. See graphql/graphql-js#1539 and graphql/graphql-js#4001. Also, the reason why graphql-ws doesn't offer built-in handling of internal errors is because there's no one-glove-fits-all. Errors are important and should be handled with care, exactly to the needs of the user - not the library author.
Regarding contributions, aside from what's stated in the contributing doc, I have no preference. You're free to open a PR or an issue, or both. IMHO, if you have a PR handy, I don't think there's a need to additionally have an issue open. All the necessary discussion can take pl…