Add store and attrs types as generics (strict) #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the store and attrs are typed as
Record<string, any>
andRecord<string, string>
respectively.This change allows them to be typed more strictly. This PR is the strict version of the change, defaulting them to
unknown
. This is the preferred type as it is correct, however the change will not be backwards-compatible. A backwards-compatible patch has also been submitted.