Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows path issue #121

Open
macdonst opened this issue Apr 9, 2024 · 1 comment
Open

Windows path issue #121

macdonst opened this issue Apr 9, 2024 · 1 comment
Assignees
@macdonst

Comments

@macdonst
Copy link
Contributor

macdonst commented Apr 9, 2024

Reported by user:

Hey hey - don't know if this is worth the whole finangle of a github pull request that will most likely get rejected, but I'm getting errors on Windows (I know, | know) with enhance.

It mangles paths with drive letters because of line 143 in _get_elements.mjs. Changing it to readFileSync(e) rather than readFileSync(fileURL.pathname) fixes it, but it might break other things. 

Just thought I'd let you know ;-)
@macdonst macdonst self-assigned this Apr 9, 2024
@macdonst
Copy link
Contributor Author

macdonst commented Apr 9, 2024

I added a test case, but I can't reproduce it. I will follow up with a poster for more details.

macdonst added a commit that referenced this issue Apr 29, 2024
@macdonst
Issue #121: Windows path issue
523e0a0 
Signed-off-by: macdonst <[email protected]>
macdonst added a commit that referenced this issue Apr 29, 2024
@macdonst
Issue #121: Windows path issue
a4731ab 
Signed-off-by: macdonst <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@macdonst macdonst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@macdonst