Skip to content

fix(ci): e2e-browser readiness must prove Phoenix, not just Vite (#964) #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rasbandit merged 3 commits into from
Jul 9, 2026
Merged

fix(ci): e2e-browser readiness must prove Phoenix, not just Vite (#964) #973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a0068c
fix(ci): e2e-browser readiness must prove Phoenix, not just Vite (#964)
Rasbandit Jul 8, 2026
1b6ad1a
chore: bump to 0.5.652 (main leapfrogged via #974)
Rasbandit Jul 9, 2026
7a87ccd
fix(ci): Vite health probe must share Phoenix's 120s boot budget
Rasbandit Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions frontend/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,12 @@ export default defineConfig({
{
command: "mix phx.server",
cwd: "..",
url: `http://localhost:${LOCAL_BACKEND_PORT}/api/health`,
// /api/health is a bare liveness check (always 200 once the Endpoint
// boots) — it doesn't prove Postgres is attached, so it can pass
// before the app can actually serve a real request. /health/deep
// round-trips Ecto.Repo, which is the earliest point the backend is
// genuinely usable (#964 — boot-race false-ready flake).
url: `http://localhost:${LOCAL_BACKEND_PORT}/api/health/deep`,
timeout: 120_000,
reuseExistingServer: !isCI,
stdout: "pipe",
Expand All @@ -69,8 +74,14 @@ export default defineConfig({
{
command: `bun run dev -- --port ${LOCAL_VITE_PORT}`,
cwd: ".",
port: LOCAL_VITE_PORT,
timeout: 15_000,
// A bare `port:` check only proves Vite accepted a TCP connection —
// not that its /api proxy can actually reach Phoenix (#964). Poll
// through the proxy so this only goes green once the whole chain
// (Vite -> proxy -> Phoenix -> Postgres) is really up.
url: `http://localhost:${LOCAL_VITE_PORT}/api/health/deep`,
// Must cover Phoenix's boot budget too: this URL proxies to Phoenix,
// so a 15s cap would fail Vite while Phoenix is still legitimately booting.
timeout: 120_000,
reuseExistingServer: !isCI,
env: {
VITE_AUTH_PROVIDER: "local",
Expand All @@ -83,7 +94,8 @@ export default defineConfig({
{
command: "mix phx.server",
cwd: "..",
url: `http://localhost:${CLERK_BACKEND_PORT}/api/health`,
// See the "local" project's Phoenix webServer entry above (#964).
url: `http://localhost:${CLERK_BACKEND_PORT}/api/health/deep`,
timeout: 120_000,
reuseExistingServer: !isCI,
stdout: "pipe" as const,
Expand All @@ -104,8 +116,10 @@ export default defineConfig({
{
command: `bun run dev -- --port ${CLERK_VITE_PORT}`,
cwd: ".",
port: CLERK_VITE_PORT,
timeout: 15_000,
// See the "local" project's Vite webServer entry above (#964).
url: `http://localhost:${CLERK_VITE_PORT}/api/health/deep`,
// Same Phoenix-boot budget as the local Vite entry above.
timeout: 120_000,
reuseExistingServer: !isCI,
env: {
VITE_AUTH_PROVIDER: "clerk",
Expand Down
2 changes: 1 addition & 1 deletion mix.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ defmodule Engram.MixProject do
def project do
[
app: :engram,
version: "0.5.651",
version: "0.5.652",
elixir: "~> 1.15",
elixirc_paths: elixirc_paths(Mix.env()),
start_permanent: Mix.env() == :prod,
Expand Down
Loading