[WIP] Test fix for map display issue in Jupyter notebooks (#23) #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create comprehensive test notebook to verify if GitHub issue #23 is fixed - Tests multiple methods of displaying polar maps in Jupyter notebooks: - HTML cell magic (previously working) - Python HTML display with URL params (previously broken) - File groups with colors - Legacy CONFIG object method - Both Arctic and Antarctic projections - polar.html now supports URL parameters which should resolve the issue 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
espg
changed the title
Contributor
📚 Documentation Preview Ready!🌐 Live PreviewURL: https://xopr-pr-33.surge.sh/xopr/ Preview updates automatically with new commits while the 📦 Download ArtifactYou can also download the docs for local viewing. Commit: To trigger a preview, add the |
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Changed from relative path (../_static/maps/polar.html) to GCS path - Use https://storage.googleapis.com/opr_stac/map/polar.html - Updated all 5 test cases in the notebook - This matches the actual deployment location of polar.html 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a test notebook to verify whether GitHub issue #23 (Map module does not display in jupyter notebooks without cell magic) is fixed with the current implementation of
polar.html.Context from Issue #23
The issue reported that the polar map module wasn't displaying properly when called from Python using
IPython.display.HTML, but worked with the%%htmlcell magic.The root cause was that there wasn't a clean way to pass the CONFIG object to the iframe when generating HTML from Python.
What Changed Since the Issue Was Opened
The
polar.htmlfile now supports URL parameters for configuration, which means the CONFIG can be passed directly in the iframe URL rather than relying on JavaScript object injection.Test Notebook
The new notebook (
docs/notebooks/test_map_display.ipynb) tests:To Verify the Fix
Related Issues
Fixes #23
🤖 Generated with Claude Code