-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Path is deprecated #28
Comments
Fixes engineerd#28 Fixes deprecation warning about "add-path". Add Path was deprecated in https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ and will be removed soon, so this PR changes the mechanism to the new one. The path is added to the ${GITHUB_PATH} file instead as described in https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#adding-a-system-path : # Please enter the commit message for your changes. Lines starting
Fixes engineerd#28 Fixes deprecation warning about "add-path". Add Path was deprecated in https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ and will be removed soon, so this PR changes the mechanism to the new one. The path is added to the ${GITHUB_PATH} file instead as described in https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#adding-a-system-path It also adds lib folder to the repository, so that we can use the action using commit hashes which is the recommended way of using actions. See: https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/security-hardening-for-github-actions#using-third-party-actions
@radu-matei any news on this? Seems that updating actions/core should fix it #27 |
I also got this error today:
Is there anything we can do to help out with this? |
We switched to our custom way of installing Kind via script :( |
I looked into this myself for Kubestack's pipelines. There's a KinD action from the helm team https://github.com/helm/kind-action But I haven't tried it yet. Just found it the other day. |
Apologies for missing this issue, I am looking into it and create a new release with the fix. However, it looks like the action version will have to be explicitly updated by the user, unfortunately. |
Created a new release which uses the updated Feel free to reopen if there is any issue related to this change. Thanks! |
See engineerd/setup-kind#28 for details Signed-off-by: Simon Pasquier <[email protected]>
See engineerd/setup-kind#28 for details Signed-off-by: Simon Pasquier <[email protected]>
See engineerd/setup-kind#28 for details. Signed-off-by: Simon Pasquier <[email protected]>
Thanks! |
When we are using setup-kind in latest version we get warning about "add-path" being deprecated.
Apparently you are using core.addPath method which also uses it.
Add Path was deprecated in https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ and will be removed soon, so I think you need to change the mechanism to the new mechanism:
The path should be added to the ${GITHUB_PATH} file instead as described in https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#adding-a-system-path :
The text was updated successfully, but these errors were encountered: