Skip to content

Commit

Permalink
Fix BidirectionalIterator deprecation warning and roll engine to a1dd…
Browse files Browse the repository at this point in the history
…50405992 (#106595)

* a1dd50405 Roll Dart SDK from 692562354d6d to 48e3f8edb811 (3 revisions) (flutter/engine#34282)

* Fix BidirectionalIterator deprecation warning

* Remove override for movePrevious

Co-authored-by: engine-flutter-autoroll <[email protected]>
  • Loading branch information
bdero and engine-flutter-autoroll authored Jun 25, 2022
1 parent 638a581 commit 8b3aabd
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion bin/internal/engine.version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4446e3edda6a3ef9dd34afcabb5ebff0747d5f93
a1dd504059925c9925ad9d36f0cf67ad8ea62eb0
6 changes: 4 additions & 2 deletions packages/flutter/lib/src/rendering/editable.dart
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ class TextSelectionPoint {
/// the [VerticalCaretMovementRun] must not be used. The [isValid] property must
/// be checked before calling [movePrevious] and [moveNext], or accessing
/// [current].
class VerticalCaretMovementRun extends BidirectionalIterator<TextPosition> {
class VerticalCaretMovementRun extends Iterator<TextPosition> {
VerticalCaretMovementRun._(
this._editable,
this._lineMetrics,
Expand Down Expand Up @@ -186,7 +186,9 @@ class VerticalCaretMovementRun extends BidirectionalIterator<TextPosition> {
return true;
}

@override
/// Move back to the previous element.
///
/// Returns true and updates [current] if successful.
bool movePrevious() {
assert(isValid);
if (_currentLine <= 0) {
Expand Down

0 comments on commit 8b3aabd

Please sign in to comment.