Pass run and drive --trace-systrace for iOS (#105321)

engine-flutter-autoroll · Jun 3, 2022 · 003f2b6 · 003f2b6
1 parent 0895130
commit 003f2b6
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 1 deletion.
diff --git a/packages/flutter_tools/lib/src/commands/run.dart b/packages/flutter_tools/lib/src/commands/run.dart
@@ -112,7 +112,8 @@ abstract class RunCommandBase extends FlutterCommand with DeviceBasedDevelopment
       ..addFlag('trace-systrace',
         negatable: false,
         help: 'Enable tracing to the system tracer. This is only useful on '
-              'platforms where such a tracer is available (Android and Fuchsia).',
+              'platforms where such a tracer is available (Android, iOS, '
+              'macOS and Fuchsia).',
       )
       ..addFlag('trace-skia',
         negatable: false,

diff --git a/packages/flutter_tools/lib/src/ios/devices.dart b/packages/flutter_tools/lib/src/ios/devices.dart
@@ -361,6 +361,7 @@ class IOSDevice extends Device {
         '--verify-entry-points',
       ],
       if (debuggingOptions.enableSoftwareRendering) '--enable-software-rendering',
+      if (debuggingOptions.traceSystrace) '--trace-systrace',
       if (debuggingOptions.skiaDeterministicRendering) '--skia-deterministic-rendering',
       if (debuggingOptions.traceSkia) '--trace-skia',
       if (debuggingOptions.traceAllowlist != null) '--trace-allowlist="${debuggingOptions.traceAllowlist}"',

diff --git a/packages/flutter_tools/test/commands.shard/hermetic/drive_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/drive_test.dart
@@ -224,6 +224,7 @@ void main() {
       '--null-assertions',
       '--native-null-assertions',
       '--enable-impeller',
+      '--trace-systrace',
       '--enable-software-rendering',
       '--skia-deterministic-rendering',
     ]), throwsToolExit());
@@ -238,6 +239,7 @@ void main() {
     expect(options.nullAssertions, true);
     expect(options.nativeNullAssertions, true);
     expect(options.enableImpeller, true);
+    expect(options.traceSystrace, true);
     expect(options.enableSoftwareRendering, true);
     expect(options.skiaDeterministicRendering, true);
   }, overrides: <Type, Generator>{

diff --git a/packages/flutter_tools/test/commands.shard/hermetic/run_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/run_test.dart
@@ -734,6 +734,7 @@ void main() {
       '--null-assertions',
       '--native-null-assertions',
       '--enable-impeller',
+      '--trace-systrace',
       '--enable-software-rendering',
       '--skia-deterministic-rendering',
     ]), throwsToolExit());
@@ -748,6 +749,7 @@ void main() {
     expect(options.verboseSystemLogs, true);
     expect(options.nullAssertions, true);
     expect(options.nativeNullAssertions, true);
+    expect(options.traceSystrace, true);
     expect(options.enableImpeller, true);
     expect(options.enableSoftwareRendering, true);
     expect(options.skiaDeterministicRendering, true);

diff --git a/packages/flutter_tools/test/general.shard/ios/ios_device_start_prebuilt_test.dart b/packages/flutter_tools/test/general.shard/ios/ios_device_start_prebuilt_test.dart
@@ -288,6 +288,7 @@ void main() {
             '--enable-checked-mode',
             '--verify-entry-points',
             '--enable-software-rendering',
+            '--trace-systrace',
             '--skia-deterministic-rendering',
             '--trace-skia',
             '--endless-trace-buffer',