Skip to content

Commit

Permalink
[ci] Replace Firebase Test Lab deprecated Pixel 4 device with Pixel 5 (
Browse files Browse the repository at this point in the history
  • Loading branch information
jmagman authored Oct 19, 2021
1 parent aae841a commit fbb7d3a
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 19 deletions.
2 changes: 1 addition & 1 deletion .cirrus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ task:
- export CIRRUS_COMMIT_MESSAGE=""
- if [[ -n "$GCLOUD_FIREBASE_TESTLAB_KEY" ]]; then
- echo $GCLOUD_FIREBASE_TESTLAB_KEY > ${HOME}/gcloud-service-key.json
- ./script/tool_runner.sh firebase-test-lab --device model=flame,version=29 --device model=starqlteue,version=26 --exclude=script/configs/exclude_integration_android.yaml
- ./script/tool_runner.sh firebase-test-lab --device model=redfin,version=30 --device model=starqlteue,version=26 --exclude=script/configs/exclude_integration_android.yaml
- else
- echo "This user does not have permission to run Firebase Test Lab tests."
- fi
Expand Down
1 change: 1 addition & 0 deletions script/tool/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## NEXT

- Update Firebase Testlab deprecated test device. (Pixel 4 API 29 -> Pixel 5 API 30).
- `native-test --android`, `--ios`, and `--macos` now fail plugins that don't
have unit tests, rather than skipping them.
- Added a new `federation-safety-check` command to help catch changes to
Expand Down
2 changes: 1 addition & 1 deletion script/tool/lib/src/firebase_test_lab_command.dart
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class FirebaseTestLabCommand extends PackageLoopingCommand {
splitCommas: false,
defaultsTo: <String>[
'model=walleye,version=26',
'model=flame,version=29'
'model=redfin,version=30'
],
help:
'Device model(s) to test. See https://cloud.google.com/sdk/gcloud/reference/firebase/test/android/run for more info');
Expand Down
34 changes: 17 additions & 17 deletions script/tool/test/firebase_test_lab_command_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ void main() {
final List<String> output = await runCapturingPrint(runner, <String>[
'firebase-test-lab',
'--device',
'model=flame,version=29',
'model=redfin,version=30',
'--device',
'model=seoul,version=26',
'--test-run-id',
Expand Down Expand Up @@ -142,7 +142,7 @@ void main() {
'/packages/plugin1/example/android'),
ProcessCall(
'gcloud',
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin1/buildId/testRunId/0/ --device model=flame,version=29 --device model=seoul,version=26'
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin1/buildId/testRunId/0/ --device model=redfin,version=30 --device model=seoul,version=26'
.split(' '),
'/packages/plugin1/example'),
ProcessCall(
Expand All @@ -156,7 +156,7 @@ void main() {
'/packages/plugin2/example/android'),
ProcessCall(
'gcloud',
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin2/buildId/testRunId/0/ --device model=flame,version=29 --device model=seoul,version=26'
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin2/buildId/testRunId/0/ --device model=redfin,version=30 --device model=seoul,version=26'
.split(' '),
'/packages/plugin2/example'),
]),
Expand All @@ -176,7 +176,7 @@ void main() {
final List<String> output = await runCapturingPrint(runner, <String>[
'firebase-test-lab',
'--device',
'model=flame,version=29',
'model=redfin,version=30',
'--device',
'model=seoul,version=26',
'--test-run-id',
Expand Down Expand Up @@ -219,7 +219,7 @@ void main() {
'/packages/plugin/example/android'),
ProcessCall(
'gcloud',
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/0/ --device model=flame,version=29 --device model=seoul,version=26'
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/0/ --device model=redfin,version=30 --device model=seoul,version=26'
.split(' '),
'/packages/plugin/example'),
ProcessCall(
Expand All @@ -229,7 +229,7 @@ void main() {
'/packages/plugin/example/android'),
ProcessCall(
'gcloud',
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/1/ --device model=flame,version=29 --device model=seoul,version=26'
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/1/ --device model=redfin,version=30 --device model=seoul,version=26'
.split(' '),
'/packages/plugin/example'),
]),
Expand Down Expand Up @@ -257,7 +257,7 @@ void main() {
<String>[
'firebase-test-lab',
'--device',
'model=flame,version=29',
'model=redfin,version=30',
'--device',
'model=seoul,version=26',
'--test-run-id',
Expand Down Expand Up @@ -294,7 +294,7 @@ void main() {
<String>[
'firebase-test-lab',
'--device',
'model=flame,version=29',
'model=redfin,version=30',
'--device',
'model=seoul,version=26',
'--test-run-id',
Expand Down Expand Up @@ -332,7 +332,7 @@ void main() {
<String>[
'firebase-test-lab',
'--device',
'model=flame,version=29',
'model=redfin,version=30',
'--device',
'model=seoul,version=26',
'--test-run-id',
Expand Down Expand Up @@ -366,7 +366,7 @@ void main() {
final List<String> output = await runCapturingPrint(runner, <String>[
'firebase-test-lab',
'--device',
'model=flame,version=29',
'model=redfin,version=30',
'--device',
'model=seoul,version=26',
'--test-run-id',
Expand Down Expand Up @@ -400,7 +400,7 @@ void main() {
final List<String> output = await runCapturingPrint(runner, <String>[
'firebase-test-lab',
'--device',
'model=flame,version=29',
'model=redfin,version=30',
'--device',
'model=seoul,version=26',
'--test-run-id',
Expand Down Expand Up @@ -445,7 +445,7 @@ void main() {
'/packages/plugin/example/android'),
ProcessCall(
'gcloud',
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/0/ --device model=flame,version=29 --device model=seoul,version=26'
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/0/ --device model=redfin,version=30 --device model=seoul,version=26'
.split(' '),
'/packages/plugin/example'),
]),
Expand All @@ -468,7 +468,7 @@ void main() {
<String>[
'firebase-test-lab',
'--device',
'model=flame,version=29',
'model=redfin,version=30',
],
errorHandler: (Error e) {
commandError = e;
Expand Down Expand Up @@ -505,7 +505,7 @@ void main() {
<String>[
'firebase-test-lab',
'--device',
'model=flame,version=29',
'model=redfin,version=30',
],
errorHandler: (Error e) {
commandError = e;
Expand Down Expand Up @@ -543,7 +543,7 @@ void main() {
<String>[
'firebase-test-lab',
'--device',
'model=flame,version=29',
'model=redfin,version=30',
],
errorHandler: (Error e) {
commandError = e;
Expand Down Expand Up @@ -571,7 +571,7 @@ void main() {
await runCapturingPrint(runner, <String>[
'firebase-test-lab',
'--device',
'model=flame,version=29',
'model=redfin,version=30',
'--test-run-id',
'testRunId',
'--build-id',
Expand Down Expand Up @@ -601,7 +601,7 @@ void main() {
'/packages/plugin/example/android'),
ProcessCall(
'gcloud',
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/0/ --device model=flame,version=29'
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/0/ --device model=redfin,version=30'
.split(' '),
'/packages/plugin/example'),
]),
Expand Down

0 comments on commit fbb7d3a

Please sign in to comment.