Enhance orientation handling in InteractivePreview and Preview classes #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Improved the handling of orientation changes in the `InteractivePreview` and `Preview` classes to ensure proper resizing and layout adjustments of the `AVCaptureVideoPreviewLayer` during device rotation. These changes address issues where the preview layer would not correctly adapt to new geometry sizes, leading to misalignment. Details: 1. `InteractivePreview`: - Added an `onChange` modifier to observe changes in the geometry size. - Updated the `layer` frame on the main dispatch queue to ensure proper resizing. 2. `Preview`: - Removed the direct assignment of `previewLayer.frame` in `updateUIViewController`. - Ensured the `previewLayer` is added to the view controller’s layer only if it hasn’t been added already. - Updated the `previewLayer.frame` on the main dispatch queue to ensure it resizes correctly when the view bounds change. NOTE: This will not affect the orientation of the session. To do that, application code must wrap the preview layer with handlers that call `aespaSession.common(.orientation(orientation: ...))`. I have some code that demonstrates this, but it's very specific to my app, so I couldn't cleanly extract a good example for the README. I can try to tackle that in a future commit.
|
Hi @subelsky. Awesome code! I’ve reviewed the code and tested it on the device and it looks good to me 👍. �I'll be merge this into the latest version for release. The issue you mentioned in your note is something I've been thinking about for a while too, but I haven't been able to crack it yet 😅. If you have some time later, I’d love for you to share some of your works. Maybe we can brainstorm and work through it together! Thanks again for your contribution! |
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improved the handling of orientation changes in the
InteractivePreviewandPreviewclasses to ensure proper resizing and layout adjustments of theAVCaptureVideoPreviewLayerduring device rotation. These changes address issues where the preview layer would not correctly adapt to new geometry sizes, leading to misalignment.Details
InteractivePreview:onChangemodifier to observe changes in the geometry size.layerframe on the main dispatch queue to ensure proper resizing.Preview:previewLayer.frameinupdateUIViewController.previewLayeris added to the view controller’s layer only if it hasn’t been added already.previewLayer.frameon the main dispatch queue to ensure it resizes correctly when the view bounds change.Note
This will not affect the orientation of the session. To do that, application code must wrap the preview layer with handlers that call
aespaSession.common(.orientation(orientation: ...)). I have some code that demonstrates this, but it's very specific to my app, so I couldn't cleanly extract a good example for the README. I can try to tackle that in a future commit.