fix(eventual-send): switch DEBUG option to be comma separated#1922
Merged
fix(eventual-send): switch DEBUG option to be comma separated#1922
Conversation
erights
force-pushed
the
markm-options-harmony
branch
2 times, most recently
from
a8e1407 to
6926eb8
Compare
erights
force-pushed
the
markm-8096-fix-debug-options-list
branch
from
283f17f to
3bc2a9c
Compare
erights
force-pushed
the
markm-options-harmony
branch
from
6926eb8 to
a802aa5
Compare
erights
force-pushed
the
markm-8096-fix-debug-options-list
branch
from
3bc2a9c to
ee26d0b
Compare
erights
force-pushed
the
markm-options-harmony
branch
from
a802aa5 to
8548770
Compare
erights
force-pushed
the
markm-8096-fix-debug-options-list
branch
from
ee26d0b to
c577e74
Compare
erights
force-pushed
the
markm-options-harmony
branch
3 times, most recently
from
ac480ad to
c2dad51
Compare
erights
force-pushed
the
markm-8096-fix-debug-options-list
branch
from
c577e74 to
0970925
Compare
erights
force-pushed
the
markm-8096-fix-debug-options-list
branch
from
0970925 to
3aaafd7
Compare
michaelfig
approved these changes
Jan 11, 2024
Contributor
|
While I agree it's technically a breaking change, I'm wondering if this particular instance warrant the churn associated with a major version bump. @kriskowal opinions? |
kriskowal
approved these changes
Jan 11, 2024
Member
kriskowal
left a comment
kriskowal
left a comment
There was a problem hiding this comment.
Sounds good to me. I do not have strong feelings about the breaking change sigil, but if it’s kept, the body of the commit must have prose for the changelog.
fix(eventual-send)!: switch DEBUG option to be comma separated
*BREAKING CHANGE*: Use `DEBUG=track-turns,etc` instead of `DEBUG=track-turns:etc`.
3aaafd7 to
fea3ba0
Compare
erights
changed the title
Contributor
Author
I got rid of it. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs: Agoric/agoric-sdk#8136
refs: Agoric/agoric-sdk#8096
refs: https://github.com/Agoric/agoric-sdk/blob/master/docs/env.md#DEBUG
Description
As explained at Agoric/agoric-sdk#8096 , prior to this PR, eventual-send's use of the
DEBUGoption mistakenly split it on colons (':'). This PR switches that one use to split on commas (',') instead.Security Considerations
Following widespread conventions leads to fewer unpleasant surprises.
Scaling Considerations
none
Documentation Considerations
https://github.com/Agoric/agoric-sdk/blob/master/docs/env.md#DEBUG already speaks in terms of the value of
DEBUGbeing a comma separated list. Prior to this PR, the endo implementation does not conform to that document. But the agoric-sdk implementation would still not conform until fixed by Agoric/agoric-sdk#8136Testing Considerations
none
Upgrade Considerations
none