lerna v5

[SMotaal]

This PR relates to #1060.

It follows the steps taken in Agoric/agoric-sdk#5927 except it bumps lerna to 5.6.2 instead of 5.1.8.

Tasks

• Dry-run Making a Release in CONTRIBUTING.md.

  Subsequent release landed — chore: release #1418

Notes

• I ran into warnings about dependency cycles tied to devDependencies: @endo/ses-ava which is similar to what was previously discussed in package dependency graph has cycles Agoric/agoric-sdk#4645.
• I ran into a failed test locally with Node.js 19.3.0 but which is not related to this PR and was reported in Delegating to JSON.parse or eval may result in unexpected SyntaxError {message} strings #1414.
• This is my first PR on this project and I am not familiar with the codebase nor the conventions, input and direction is greatly appreciated.

[turadg]

This is my first PR on this project and I am not familiar with the codebase nor the conventions, input and direction is greatly appreciated.

Changes look fine. The conventions are mostly around source code, of which there is none in this PR.

The most important thing is that it works, so the test plan should be thorough. This includes at least the test plan in Agoric/agoric-sdk#5927 . It should also test publishing, which I think you can do with a dry run locally (it will generate Git tags which must not be pushed to endojs repo, but you don't have to worry about that because you're working from a fork)

[SMotaal]

@turadg I'm not sure I understand what I need to do next on my end.

---

I am seeing 2 workflows awaiting approval before they can run.

Q: Does it make sense to approve them now so we can get some more insights?

---

The most important thing is that it works, so the test plan should be thorough. This includes at least the test plan in Agoric/agoric-sdk#5927.

• yarn works
• yarn build works
• yarn test works

  apart from the one I mentioned in the description which is not related to the PR.

• yarn lerna exec npm pkg get name |grep ": " | wc -l works

  31 packages

Q: Can you clarify please if I am missing what you specifically had in mind re Agoric/agoric-sdk#5927?

---

It should also test publishing, which I think you can do with a dry run locally (it will generate Git tags which must not be pushed to endojs repo, but you don't have to worry about that because you're working from a fork)

• Here I am pausing as I am not sure how far along endojs/endo is publishing wise.
• Also worth noting here — Better yarn publish yarnpkg/yarn#610

Q: Can you please point me to an issue or reference as a template for me to follow?

[turadg]

Q: Does it make sense to approve them now so we can get some more insights?

Yes, I hadn't seen that button. Clicked.

The most important thing is that it works, so the test plan should be thorough. This includes at least the test plan in Agoric/agoric-sdk#5927.

• yarn works
• yarn build works
• yarn test works

  apart from the one I mentioned in the description which is not related to the PR.

• yarn lerna exec npm pkg get name |grep ": " | wc -l works

  31 packages

Q: Can you clarify please if I am missing what you specifically had in mind re Agoric/agoric-sdk#5927?

Nothing missing; that's the test plan I pointed to as "at least". Glad to see it's working.

It should also test publishing, which I think you can do with a dry run locally (it will generate Git tags which must not be pushed to endojs repo, but you don't have to worry about that because you're working from a fork)

• Here I am pausing as I am not sure how far along endjs/endo is publishing wise.
  Not sure what you're asking but Endo is publishing to NPM regularly. See https://www.npmjs.com/org/endo .

• Also worth noting here — Better yarn publish yarnpkg/yarn#610

Q: Can you please point me to an issue or reference as a template for me to follow?

It's the standard Lerna workflow. #1340 is an example of a version bump to release.

[kriskowal]

This looks good to me. Please promote from draft to ready-for-review and either @turadg or I will review and merge. I’ll keep an eye on whether Lerna keeps doing the right thing when I cut releases again, which will be soon.

[SMotaal]

I’ll keep an eye on whether Lerna keeps doing the right thing when I cut releases again, which will be soon.

@kriskowal Updated description to reflect this… Promoting 🎉

[turadg]

LGTM. I recall something about useNx defaulting to true now, but that's not until Lerna 6.

My only outstanding concern is that it work with the publish flow, but since @kriskowal has agreed to handle that I think this is good to land.

Thanks for the contribution @SMotaal !