Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(bundle-source): pin to a fixed rollup tarball #1154

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

michaelfig
Copy link
Member

@michaelfig michaelfig commented Apr 13, 2022

Fix the following override mistake in Rollup used by endo/packages/bundle-source that rears its head when some apparently unrelated package uses hasOwnProperty:

2022-04-13T00:38:54.385Z ag-solo: solo [ 'start' ]
(TypeError#1)
TypeError#1: Override property hasOwnProperty
  at Object.setter (file:///private/var/folders/67/vylk7hzs6v72jwj0gjbq205w0000gp/T/agoric-cli-test--42195-9cOV8ApJw4EU/dapp-foo/node_modules/ses/dist/ses.umd.js:5943:27)
  at MagicString.overwrite (file:///private/var/folders/67/vylk7hzs6v72jwj0gjbq205w0000gp/T/agoric-cli-test--42195-9cOV8ApJw4EU/dapp-foo/node_modules/rollup/dist/es/shared/rollup.js:812:30)
  at Identifier.render (file:///private/var/folders/67/vylk7hzs6v72jwj0gjbq205w0000gp/T/agoric-cli-test--42195-9cOV8ApJw4EU/dapp-foo/node_modules/rollup/dist/es/shared/rollup.js:6469:22)
  at Property.render (file:///private/var/folders/67/vylk7hzs6v72jwj0gjbq205w0000gp/T/agoric-cli-test--42195-9cOV8ApJw4EU/dapp-foo/node_modules/rollup/dist/es/shared/rollup.js:11028:20)
[...]

Our friend @Jack-Works has already landed a patch upstream for this problem, but it has not yet made it into a published rollup version.

@michaelfig michaelfig added the bug Something isn't working label Apr 13, 2022
@michaelfig michaelfig self-assigned this Apr 13, 2022
Copy link
Member

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave a note somewhere to look for the upstream fix in Rollup, so we know to remove the hack when the permanent fix is available.

@michaelfig michaelfig merged commit aebabe8 into master Apr 13, 2022
@michaelfig michaelfig deleted the mfig-bundle-source-override-mistake branch April 13, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants